Maganty Rushyendra 4ef246f804 Fix unsigned integer bug in LocalVector::erase ...

`erase()` calls `find()` to get the index of the element to remove, if
any.

c2151e1813/core/local_vector.h (L77-L81)

`find()` returns a signed integer. In particular, it returns -1 if
no element is found. Since `erase()` converts this to an unsigned type, the
wrong element may be erroneously removed from the vector.

Other ways to fix this would involve changing function signatures, so
this seemed to be the least disruptive change.

Fixes #38884

2020-05-27 21:53:34 +08:00

6.4 KiB

Raw Blame History

View Raw