godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-03 11:50:27 +00:00
Code Releases Wiki Activity

Merge pull request #112268 from YeldhamDev/solar_flare

Browse Source 
Fix contrast for light color presets in the classic theme
This commit is contained in:
Rémi Verschelde
2025-11-01 19:06:47 +01:00
parent 402805d26f ee76f3d93e
commit efeb1201f4
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
editor/themes/editor_theme_manager.cpp
View File

@@ -318,6 +318,9 @@ EditorThemeManager::ThemeConfiguration EditorThemeManager::_create_theme_config(
bool preset_draw_extra_borders = false;
float preset_icon_saturation = config.default_icon_saturation;
// A negative contrast rate looks better for light themes, since it better follows the natural order of UI "elevation".
const float light_contrast = config.style == "Modern" ? -0.4 : -0.06;
// Please use alphabetical order if you're adding a new color preset here.
if (config.preset == "Black (OLED)") {
preset_accent_color = Color(0.45, 0.75, 1.0);
@@ -342,8 +345,7 @@ EditorThemeManager::ThemeConfiguration EditorThemeManager::_create_theme_config(
} else if (config.preset == "Light") {
preset_accent_color = Color(0.18, 0.50, 1.00);
preset_base_color = Color(0.9, 0.9, 0.9);
// A negative contrast rate looks better for light themes, since it better follows the natural order of UI "elevation".
preset_contrast = -0.4;
preset_contrast = light_contrast;
} else if (config.preset == "Solarized (Dark)") {
preset_accent_color = Color(0.15, 0.55, 0.82);
preset_base_color = Color(0.03, 0.21, 0.26);
@@ -351,8 +353,7 @@ EditorThemeManager::ThemeConfiguration EditorThemeManager::_create_theme_config(
} else if (config.preset == "Solarized (Light)") {
preset_accent_color = Color(0.15, 0.55, 0.82);
preset_base_color = Color(0.89, 0.86, 0.79);
// A negative contrast rate looks better for light themes, since it better follows the natural order of UI "elevation".
preset_contrast = -0.4;
preset_contrast = light_contrast;
} else { // Default
preset_accent_color = Color(0.337, 0.62, 1.0);
preset_base_color = Color(0.145, 0.145, 0.145);