godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

Merge pull request #88665 from KoBeWi/nice_help_bro

Browse Source 
Fix implementation of `property_can_revert()` in PropertyListHelper
This commit is contained in:
Rémi Verschelde
2024-02-22 16:39:44 +01:00
parent 43771659cb 5473c7e222
commit c17f3d7c05
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
doc/classes/Object.xml
View File

@@ -220,7 +220,7 @@
<return type="bool" />
<param index="0" name="property" type="StringName" />
<description>
Override this method to customize the given [param property]'s revert behavior. Should return [code]true[/code] if the [param property] can be reverted in the Inspector dock. Use [method _property_get_revert] to specify the [param property]'s default value.
Override this method to customize the given [param property]'s revert behavior. Should return [code]true[/code] if the [param property] has a custom default value and is revertible in the Inspector dock. Use [method _property_get_revert] to specify the [param property]'s default value.
[b]Note:[/b] This method must return consistently, regardless of the current value of the [param property].
</description>
</method>

7
scene/property_list_helper.cpp
View File

@@ -111,12 +111,7 @@ bool PropertyListHelper::property_set_value(const String &p_property, const Vari
bool PropertyListHelper::property_can_revert(const String &p_property) const {
int index;
const Property *property = _get_property(p_property, &index);
if (property) {
return _call_getter(property->getter, index) != property->default_value;
}
return false;
return _get_property(p_property, &index) != nullptr;
}
bool PropertyListHelper::property_get_revert(const String &p_property, Variant &r_value) const {