godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Merge pull request #110240 from westenral/add_int_division_warnings

Browse Source 
Add checks for integer vectors for integer division warning
This commit is contained in:
Thaddeus Crews
2025-09-30 20:10:33 -05:00
parent e22d442bf6 565e1aaeb9
commit b9730c0b2e
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/gdscript/gdscript_analyzer.cpp
View File

@@ -3102,7 +3102,13 @@ void GDScriptAnalyzer::reduce_binary_op(GDScriptParser::BinaryOpNode *p_binary_o
}
#ifdef DEBUG_ENABLED
if (p_binary_op->variant_op == Variant::OP_DIVIDE && left_type.builtin_type == Variant::INT && right_type.builtin_type == Variant::INT) {
if (p_binary_op->variant_op == Variant::OP_DIVIDE &&
(left_type.builtin_type == Variant::INT ||
left_type.builtin_type == Variant::VECTOR2I ||
left_type.builtin_type == Variant::VECTOR3I ||
left_type.builtin_type == Variant::VECTOR4I) &&
(right_type.builtin_type == Variant::INT ||
right_type.builtin_type == left_type.builtin_type)) {
parser->push_warning(p_binary_op, GDScriptWarning::INTEGER_DIVISION);
}
#endif // DEBUG_ENABLED