godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Prevent invalid and ambiguous tag names

Browse Source
This commit is contained in:
kobewi
2025-07-28 20:25:05 +02:00
parent 2d113cc224
commit 529860e36c
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
editor/project_manager/project_manager.cpp
View File

@@ -1014,6 +1014,24 @@ void ProjectManager::_set_new_tag_name(const String p_name) {
return;
}
if (p_name[0] == '_' || p_name[p_name.length() - 1] == '_') {
tag_error->set_text(TTRC("Tag name can't begin or end with underscore."));
return;
}
bool was_underscore = false;
for (const char32_t &c : p_name.span()) {
if (c == '_') {
if (was_underscore) {
tag_error->set_text(TTRC("Tag name can't contain consecutive underscores."));
return;
}
was_underscore = true;
} else {
was_underscore = false;
}
}
for (const String &c : forbidden_tag_characters) {
if (p_name.contains(c)) {
tag_error->set_text(vformat(TTRC("These characters are not allowed in tags: %s."), String(" ").join(forbidden_tag_characters)));
@@ -1830,6 +1848,8 @@ ProjectManager::ProjectManager() {
create_tag_btn->set_accessibility_name(TTRC("Create Tag"));
all_tags->add_child(create_tag_btn);
create_tag_btn->connect(SceneStringName(pressed), callable_mp((Window *)create_tag_dialog, &Window::popup_centered).bind(Vector2i(500, 0) * EDSCALE));
_set_new_tag_name("");
}
// Initialize project list.