godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-10 13:00:37 +00:00
Code Releases Wiki Activity

Fix file handle leak in ZipArchive and FileAccessZip

Browse Source
This commit is contained in:
Mateo "Kuruk" Miccino
2025-02-23 10:25:34 -03:00
parent 88b9932ce1
commit 38c69f1814
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/io/file_access_zip.cpp
View File

@@ -174,7 +174,6 @@ bool ZipArchive::try_open_pack(const String &p_path, bool p_replace_files, uint6
Package pkg; Package pkg;
pkg.filename = p_path; pkg.filename = p_path;
pkg.zfile = zfile;
packages.push_back(pkg); packages.push_back(pkg);
int pkg_num = packages.size() - 1; int pkg_num = packages.size() - 1;
@@ -201,6 +200,8 @@ bool ZipArchive::try_open_pack(const String &p_path, bool p_replace_files, uint6
} }
} }
unzClose(zfile);
return true; return true;
} }
@@ -225,10 +226,6 @@ ZipArchive::ZipArchive() {
} }
ZipArchive::~ZipArchive() { ZipArchive::~ZipArchive() {
for (int i = 0; i < packages.size(); i++) {
unzClose(packages[i].zfile);
}
packages.clear(); packages.clear();
} }

1
core/io/file_access_zip.h
View File

@@ -47,7 +47,6 @@ public:
private: private:
struct Package { struct Package {
String filename; String filename;
unzFile zfile = nullptr;
}; };
Vector<Package> packages; Vector<Package> packages;