Rindbee
075e79bf04
Improve validation when setting max/min/page in Range
...
The incoming value is validated first and then compared.
Previously, when the ScrollContainer was scrolled, the ScrollBar of
the other axis of the ScrollContainer would emit the changed signal.
This commit avoids that.
2022-10-20 14:04:09 +08:00
George L. Albany
d846dd6e91
Make BaseButton Shortcut feedback togglable
2022-10-20 02:02:12 -04:00
Max Hilbrunner
d148613bb1
Merge pull request #66279 from aaronfranke/control-min-size
...
Revert `custom_minimum_size` type back to `Vector2` instead of `Vector2i`
2022-10-19 22:40:52 +02:00
kobewi
d06a8320e5
Simplify GDVIRTUAL_CALL calls
2022-10-19 00:05:48 +02:00
kobewi
b42c1f82fc
Improve ColorPicker sliders in OKHSL mode
2022-10-18 23:59:55 +02:00
kobewi
e48c5daddf
Unify usage of GLOBAL/EDITOR_GET
2022-10-18 19:01:48 +02:00
Markus Sauermann
b8031bb7d6
Code simplifications
...
1. Viewport::get_visible_rect().position is always zero.
So Control::get_window_rect is identical to Control::get_global_rect.
Remove Control::get_window_rect since it is not used in the source code.
2. sqrt(a * a) = abs(a) for doubles
3. Simplify affine_inverse combination
4. Simplify calculation in shaders
2022-10-18 12:47:40 +02:00
PucklaMotzer09
e5354cacd0
Add Caret Insert Below and Above shortcuts to TextEdit
2022-10-18 10:38:53 +02:00
Rindbee
42073fc2bb
Use more reasonable scrollable conditions in ScrollContainer
...
The visibility of the `ScrollBar` was used as a condition for judging whether it should scroll.
**Visible** and **scrollable** are currently not the same in some cases (`SCROLL_MODE_SHOW_NEVER`).
This makes `SCROLL_MODE_SHOW_NEVER` not working properly.
This patch will make `SCROLL_MODE_SHOW_NEVER` available, so that the external `SrollBar` can
share the internal `ScrollBar`'s data, we can achieve the purpose of replacing the internal
`ScrollBar` with a custom external one.
2022-10-18 16:32:39 +08:00
arkology
825f5671f1
Support AtlasTexture in radial modes of TextureProgressBar
2022-10-17 20:44:25 +03:00
Markus Sauermann
13b87c13c7
Fix set_as_toplevel event propagation to child
...
In certain conditions events did not get propagated to Control childs of
Node2D nodes when setting a parent of the Node2D to toplevel.
This patch makes sure that such Control nodes become root control in the
viewport.
2022-10-16 21:42:16 +02:00
Paulb23
4bfb1d953c
Fix undo redo not adjusting TextEdit viewport to caret
2022-10-16 19:30:03 +01:00
Paulb23
b5dc8e24be
Fix crash in code completion when using an invalid / null font
2022-10-16 16:47:27 +01:00
Paulb23
76005e5ff7
Forcibly end current TextEdit action on undo redo
2022-10-16 16:28:22 +01:00
bruvzg
4b1937c73f
Abort LineEdit shaping if no font is set to avoid unnecessary error messages.
2022-10-14 12:57:42 +03:00
Rémi Verschelde
f32f5b70d8
Merge pull request #67348 from Mickeon/salvage-a-dear-comment
...
Comment not to remove `data` structs in some Nodes
2022-10-13 18:40:58 +02:00
Micky
de9e08da76
Comment not to remove data structs in some Nodes
2022-10-13 15:52:35 +02:00
Rémi Verschelde
2ffb609658
Merge pull request #66337 from EricEzaM/sprite-frames
...
Ensure control built-in shortcuts are matched exactly & add shortcuts for SpriteFrames editor
2022-10-13 15:24:39 +02:00
Rémi Verschelde
17db8be33c
Merge pull request #66357 from EricEzaM/shortcut-context-on-node
...
Move Shortcut Context to control and fix `shortcut_input` with `shortcut_context`
2022-10-13 15:24:30 +02:00
Eric M
a3ed9e6f2c
Move Shortcut Context to Control and ensure that shortcut_input adheres to contexts. Also ensure that controls with no context are only triggered AFTER nodes which do have a context.
2022-10-13 21:07:19 +10:00
MladoniSzabi
3550354fd3
fixed holding alt while zooming zooms in by 2 increments.
2022-10-13 11:38:25 +01:00
Rémi Verschelde
fad0327503
Merge pull request #66953 from Sauermann/fix-top-level-connect-error
...
Fix Control node not disconnecting from signal
2022-10-13 09:04:25 +02:00
Rémi Verschelde
15b68f7601
Merge pull request #67232 from bruvzg/popup_edit
...
Improve Popup / Window behavior in the edited scene tree.
2022-10-12 14:45:14 +02:00
Paulb23
f3eb543e67
Fix select word under caret using caret col instead of line
2022-10-11 20:32:06 +01:00
kobewi
a3661ad079
Remove editor dependencies from ColorPicker
2022-10-11 16:09:27 +02:00
Rémi Verschelde
f21053d189
Merge pull request #67201 from progsource/richtextlabel-icon-spritesheet
...
Add Spritesheet support to RichTextLabel BBCode
2022-10-11 13:58:54 +02:00
Petra Baranski
546e017613
Add Spritesheet support to RichTextLabel BBCode
...
BBCode: [img region=0,0,16,16]res://icon.svg[/img]
2022-10-11 13:04:15 +02:00
bruvzg
2e1fcbe14b
Prevent Popups it the edited scene tree from closing on focus loss. Hide irrelevant Popup flags from the editor inspector.
2022-10-11 08:55:00 +03:00
Rémi Verschelde
8017827144
SCons: Re-enable treating #warning as error with werror
...
Replace all TODO uses of `#warning` by proper TODO comments, and will open
matching bug reports to keep track of them.
We don't have a great track record fixing TODOs, but I'd wager we're even
worse for fixing these "TODO #warning" so we should prohibit this usage.
2022-10-10 16:12:26 +02:00
Rémi Verschelde
ddb97a0b35
Merge pull request #67117 from Jummit/tree-button-color
...
Expose TreeItem::set_button_color
2022-10-10 13:52:57 +02:00
Rémi Verschelde
4be5660223
Merge pull request #67145 from Paulb23/tab_textedit
...
Fix inserting tabs in TextEdit
2022-10-10 13:52:42 +02:00
Rémi Verschelde
104af08e9d
Merge pull request #65805 from MewPurPur/improve-breakpoint-hovering
...
Improve bookmark and breakpoint indicators
2022-10-10 10:03:26 +02:00
VolTer
d6e60f45a1
Improved breakpoints hover indicator
2022-10-10 04:36:45 +02:00
Haoyu Qiu
eac9adf7a1
Don't allow removing TextEdit's main caret
2022-10-10 08:30:23 +08:00
Paulb23
7333aa68f4
Handle tab in TextEdit
2022-10-09 17:46:40 +01:00
Jummit
a6c1cfae99
Allow drag-clicking before symbol lookup
...
This makes it easier for touch and tablet users to do symbol lookups in
the code editor.
2022-10-09 18:42:54 +02:00
Rémi Verschelde
6f6482e82b
Merge pull request #67083 from RedMser/label-font-warning
...
Add warning for missing characters in label font
2022-10-09 18:29:06 +02:00
Rémi Verschelde
49be2d2cf8
Merge pull request #66524 from microaeris/aeris/text-edit-get-scroll-bar
...
Getters for TextEdit scroll bars
2022-10-09 18:27:30 +02:00
Rindbee
3f20108703
Improve caret drawing conditions for LineEdit
...
Now, `caret_can_draw` will be validated when a condition that affects
the drawability of the `LineEdit`'s caret changes; `draw_caret` will
be toggled when the caret's visibility is toggled due to blink, and
`draw_caret` will be `false` when `caret_blink_enabled` is disabled.
Fix toggling `caret_blink_enabled` could cause caret to no longer be
displayed.
Fix opening the context menu causing caret to no longer appear.
2022-10-09 22:14:40 +08:00
Jummit
1e28675560
Expose TreeItem::set_button_color
2022-10-09 10:37:55 +02:00
Haoyu Qiu
2a921cc9f8
Fix Label text length mismatch after localization
2022-10-08 23:07:19 +08:00
RedMser
9579d49820
Add warning for missing characters in label font
2022-10-08 17:02:25 +02:00
microaeris
215fe852b8
Getters for TextEdit scrollbars
2022-10-07 23:16:04 -07:00
bruvzg
0103af1ddd
Fix MSVC warnings, rename shadowed variables, fix uninitialized values, change warnings=all to use /W4.
2022-10-07 11:32:33 +03:00
Rémi Verschelde
5b7f62af55
Merge pull request #62910 from Vitika9/gsoc-colorpicker-ux
...
ColorPicker UX
2022-10-07 09:49:29 +02:00
bruvzg
a750ca7ec1
Add split caret direction markers. Fix block/overtype caret size.
2022-10-07 08:45:52 +03:00
Rémi Verschelde
d414872bfe
Merge pull request #66961 from Rindbee/fix-set_custom_color
...
Fix wrong condition used in `set_custom_color`
2022-10-06 08:56:52 +02:00
Rémi Verschelde
f5903215d0
Merge pull request #61902 from Paulb23/multi-caret
...
Add Multi-caret support to TextEdit
2022-10-06 08:56:34 +02:00
Rindbee
f359abbe01
Fix wrong condition used in set_custom_color
2022-10-06 12:09:02 +08:00
Markus Sauermann
c0f0f26615
Fix Control not disconnecting signal
...
If a Control has not parent CanvasItem and is set as top_level, then it does not disconnect from the "size_changed" signal when it leaves the Canvas.
This patch corrects this.
2022-10-05 23:35:44 +02:00
