1
0
mirror of https://github.com/godotengine/godot.git synced 2025-11-17 14:11:06 +00:00
Commit Graph

55570 Commits

Author SHA1 Message Date
baptr
2eadbe7b78 Fix multiplayer replication crash in on_sync_receive.
A number of early continue cases applied the packet-provided `size`
without validation, allowing large uint32_t values to be treated as
negative offsets and leading to segfaults.

Now, we validate `size` against the buffer length immediately to avoid a
crash.

This could be triggered by receiving sync data for a synchronizer who's
root node had just been removed, since the code path that checked for
unusable sync state failed to advance the offset. Thus the next read
could interpret part of the payload as such an invalid `size`.

Now, we properly advance the read offset in that case (and raise a
better error).
2023-02-14 02:46:32 -08:00
Rémi Verschelde
d2699dc7ab Merge pull request #73275 from Mickeon/doc-color-oops
Fix incorrect format in Color documentation
2023-02-14 11:07:03 +01:00
Rémi Verschelde
76876a7337 Merge pull request #73259 from KoBeWi/spaghetti_map
Fix some TileMap errors and crashes
2023-02-14 11:06:39 +01:00
Rémi Verschelde
78ccf71dfb Merge pull request #73269 from bruvzg/ed_prog2
[Editor] Fix editor progress dialog auto closing on ESC press, and on application focus loss.
2023-02-14 11:06:16 +01:00
Rémi Verschelde
570b04dec4 Merge pull request #73265 from clayjohn/tangent-oct
Bias octahedral tangent y axis to avoid errors around 0
2023-02-14 11:05:52 +01:00
Rémi Verschelde
1a206d0e22 Merge pull request #73263 from clayjohn/render_priority
Notify mesh surface when render_priority changes
2023-02-14 11:05:28 +01:00
Rémi Verschelde
44ad635505 Merge pull request #73261 from smix8/fix_tilemap_invalid_rid_error_4.x
Fix TileMap NavigationServer 'Invalid ID' error
2023-02-14 11:05:05 +01:00
Rémi Verschelde
1fcee45ae5 Merge pull request #73252 from smix8/navigationserver_improve_rid_not_found_error_4.x
Improve NavigationServer.free() error msg when RID not found
2023-02-14 11:04:40 +01:00
Rémi Verschelde
bed1ebd527 Merge pull request #72259 from Paulb23/json-editing
Support editing JSON in ScriptEditor
2023-02-14 11:04:17 +01:00
Rémi Verschelde
bfe43f69b8 Merge pull request #67707 from Cykyrios/hide-private-prop-description-in-classdoc
Fix private properties appearing in custom class doc Property Descriptions
2023-02-14 11:03:50 +01:00
Rémi Verschelde
1f18e16a32 Merge pull request #73255 from clayjohn/GLES3-batch-blend
Store blend mode between CanvasItems to preserve batching
2023-02-14 11:01:44 +01:00
Micky
8d0078873a Fix incorrect format in Color documentation 2023-02-14 10:27:43 +01:00
Micky
edb78840c0 Add missing documentation for String & StringName
Also fixes typos brought up in #69821's replies.
2023-02-14 10:15:44 +01:00
bruvzg
39b69e6f76 [Editor] Fix editor progress dialog auto closing on ESC press, and on application focus loss. 2023-02-14 09:23:40 +02:00
bruvzg
a322f3f578 [InputEventKey] Avoid setting both key and modifier to the same value. 2023-02-14 09:05:58 +02:00
clayjohn
5a800e68f1 Bias octahedral tangent y axis to avoid errors around 0 2023-02-13 19:24:14 -08:00
clayjohn
d3b3419aff Notify mesh surface when render_priority changes
This ensures that the mesh properly takes render_priority into account when changed
2023-02-13 18:09:33 -08:00
smix8
fef6ffabe5 Fix TileMap NavigationServer 'Invalid ID' error
Fixes NavigationServer 'Invalid ID' error of the TileMap.
The issue was not caused directly by the TileMap but with the late call to get_world_2d()->get_navigation_map() while everything is shut down abruptly e.g. game window closed or Editor "Reload Saved Scene" function.
2023-02-14 01:39:21 +01:00
Chris Hutchinson
cb8e919243 Replaced operating system alert dialog with a warning log message,
toggled by a project setting.
Fixes #73141
2023-02-13 18:42:43 -05:00
kobewi
be6d5bbba6 Fix some TileMap errors and crashes 2023-02-14 00:39:41 +01:00
Ryan Roden-Corrent
806425621c Disable local space for blender transforms.
Having local_space enabled when starting a transform changed the
behavior of VIEW space transforms. Now we disable local_space when
starting a blender transform (there was already logic to restore the
setting after the transform ends).

This also hides the gizmo while performing a blender transform,
otherwise the user will see it snap back and forth between the local and
global alignment. I think the transform looks cleaner with the gizmo
hidden anyways.

Fixes #59392.
2023-02-13 18:09:44 -05:00
clayjohn
ab4e79cd03 Store blend mode between CanvasItems to preserve batching 2023-02-13 14:46:26 -08:00
Rémi Verschelde
4848877b80 Merge pull request #72659 from Calinou/doc-rendering-method-support
Document unsupported features in Mobile and Compatibility rendering methods
2023-02-13 23:45:12 +01:00
Rémi Verschelde
9721d557d0 Merge pull request #73248 from constantitus/characterbody2d-csharp-doc
fixed c# example in CharacterBody2D doc
2023-02-13 23:44:48 +01:00
Julien Reichardt
0cec4fcc65 Fix Standard Gamepad Mapping triggers 2023-02-13 23:44:43 +01:00
Rémi Verschelde
81bfc8c7d6 Merge pull request #61492 from Calinou/decal-clamp-extents
Clamp Decal size to positive values
2023-02-13 23:44:24 +01:00
smix8
b51cab3411 Improve NavigationServer.free() error msg when RID not found
Improves the error msg when NavigationServer.free() does not find the RID e.g. because it was already deleted or did never exist in the first place.
2023-02-13 23:44:05 +01:00
Rémi Verschelde
02a9a31b1b Merge pull request #73244 from vonagam/fix-int-in-float-typed-array
GDScript: Fix usage of ints with typed array of floats
2023-02-13 23:43:09 +01:00
kobewi
390bb23675 Improve Image preview in the inspector 2023-02-13 23:03:38 +01:00
Hugo Locurcio
42b7739321 Document unsupported features in Mobile and Compatibility rendering methods 2023-02-13 22:17:02 +01:00
constantitus
6951574265 fixed c# example in CharacterBody2D doc 2023-02-13 23:14:48 +02:00
Hugo Locurcio
8b1de103a8 Clamp Decal size to positive values
This prevents using negative size, while also preventing
error messages from being spammed if one of the decal's dimensions
is set to exactly 0.
2023-02-13 22:01:49 +01:00
Pawel Lampe
e92adba19c Add initial navigation tests 2023-02-13 21:39:09 +01:00
QbieShay
7881422901 make particle billboard take into account non-uniform scale 2023-02-13 21:18:55 +01:00
Rémi Verschelde
853c36ca0b Merge pull request #61411 from snailrhymer/tilemap-editor-scattering
Fix random placement behaviour in new TileMap Editor
2023-02-13 21:14:40 +01:00
Rémi Verschelde
49fd62c315 Merge pull request #67523 from zaevi/fix_ProjectManager_sorting
Fix sorting issue in Project Manager.
2023-02-13 21:07:58 +01:00
Rémi Verschelde
c787eb6609 Merge pull request #66476 from GK-GreyGhost/csgbox-updater
Support CSGBox3D conversion of width/height/depth in 3 to size in 4
2023-02-13 21:07:30 +01:00
Rémi Verschelde
0668e0f5a9 Merge pull request #69001 from dzil123/fix_rendering_checks
Fix various missing rendering parameter checks
2023-02-13 21:07:05 +01:00
Dmitrii Maganov
9cb2da89d6 GDScript: Fix usage of ints with typed array of floats 2023-02-13 22:06:38 +02:00
Rémi Verschelde
c2e1be66c8 Merge pull request #72870 from Calinou/doc-directionallight2d-no-cull-mask
Document DirectionalLight2D not supporting cull masks
2023-02-13 21:06:33 +01:00
Rémi Verschelde
e78b77481e Merge pull request #73240 from myaaaaaaaaa/worker-h
Move some `worker_thread_pool.h` includes out of header files
2023-02-13 21:05:57 +01:00
DESKTOP-9O27V4U\Navi
ac92704f39 Add compatibility code for CSGBox3D width/height/depth from Godot 3.x
Fixes #66420.
2023-02-13 20:41:23 +01:00
Rémi Verschelde
854d9c3d9c Merge pull request #73239 from bruvzg/cleanup_callback
Cleanup Window callbacks before destroying in to avoid callback calls with invalid object.
2023-02-13 20:24:29 +01:00
myaaaaaaaaa
6f88392d02 Move some worker_thread_pool.h includes out of header files 2023-02-13 14:02:01 -05:00
bruvzg
a000c64eea Cleanup Window callbacks before destroying in to avoid callback calls with invalid object. 2023-02-13 20:39:17 +02:00
kobewi
0c71c443ef Fix corrupt undo after making sub-resources unique 2023-02-13 19:18:03 +01:00
Rémi Verschelde
3815903119 Merge pull request #72838 from BastiaanOlij/update_screen_space_render_buffers
Add render buffer support to screen space effects
2023-02-13 19:15:48 +01:00
Rémi Verschelde
1ecf486ef0 Merge pull request #73234 from RandomShaper/fix_label_sizing
Fix blank non-autowrapping labels
2023-02-13 19:14:51 +01:00
Pedro J. Estébanez
3ccabee9ae Fix blank non-autowrapping labels 2023-02-13 18:46:56 +01:00
Rémi Verschelde
cf859db34a Merge pull request #73214 from reduz/prevent-recursive-importing-hack
Prevent recursive importing (hack)
2023-02-13 18:23:35 +01:00