godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Merge pull request #112227 from dsnopek/openxr-composition-layers-viewport-size-changed

Browse Source 
OpenXR: Fix resizing viewports used by `OpenXRCompositionLayer`
This commit is contained in:
Thaddeus Crews
2025-10-31 09:23:24 -05:00
parent bb5c32abbe ca0eb5da24
commit fd672dbcfc
5 changed files with 30 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/openxr/extensions/openxr_composition_layer_extension.cpp
View File

@@ -232,6 +232,8 @@ void OpenXRCompositionLayerExtension::CompositionLayer::set_viewport(RID p_viewp
free_swapchain();
subviewport.viewport_size = Size2i();
}
} else if (subviewport.viewport_size != p_size) {
subviewport.viewport_size = p_size;
}
}

12
modules/openxr/scene/openxr_composition_layer.cpp
View File

@@ -244,6 +244,12 @@ void OpenXRCompositionLayer::_clear_composition_layer() {
}
}
void OpenXRCompositionLayer::_viewport_size_changed() {
if (layer_viewport && openxr_session_running && composition_layer_extension && is_natively_supported() && is_visible() && is_inside_tree()) {
composition_layer_extension->composition_layer_set_viewport(composition_layer, layer_viewport->get_viewport_rid(), layer_viewport->get_size());
}
}
void OpenXRCompositionLayer::_on_openxr_session_begun() {
openxr_session_running = true;
if (_should_register()) {
@@ -298,12 +304,18 @@ void OpenXRCompositionLayer::set_layer_viewport(SubViewport *p_viewport) {
ERR_FAIL_COND_MSG(p_viewport != nullptr, RTR("Cannot set SubViewport on an OpenXR composition layer when using an Android surface."));
}
if (layer_viewport) {
layer_viewport->disconnect("size_changed", callable_mp(this, &OpenXRCompositionLayer::_viewport_size_changed));
}
layer_viewport = p_viewport;
if (_should_register()) {
_setup_composition_layer();
}
if (layer_viewport) {
layer_viewport->connect("size_changed", callable_mp(this, &OpenXRCompositionLayer::_viewport_size_changed));
SubViewport::UpdateMode update_mode = layer_viewport->get_update_mode();
if (update_mode == SubViewport::UPDATE_WHEN_VISIBLE || update_mode == SubViewport::UPDATE_WHEN_PARENT_VISIBLE) {
WARN_PRINT_ONCE("OpenXR composition layers cannot use SubViewports with UPDATE_WHEN_VISIBLE or UPDATE_WHEN_PARENT_VISIBLE. Switching to UPDATE_ALWAYS.");

2
modules/openxr/scene/openxr_composition_layer.h
View File

@@ -115,6 +115,8 @@ private:
void _setup_composition_layer();
void _clear_composition_layer();
void _viewport_size_changed();
protected:
OpenXRAPI *openxr_api = nullptr;
OpenXRCompositionLayerExtension *composition_layer_extension = nullptr;