godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-31 18:41:20 +00:00
Code Releases Wiki Activity

Use RequiredParam/RequiredResult in some high value places

Browse Source
This commit is contained in:
David Snopek
2025-11-27 13:09:16 -06:00
parent 3a97723ff2
commit fc92ce3e7f
79 changed files with 372 additions and 321 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/core/object/test_object.h
View File

@@ -620,4 +620,17 @@ TEST_CASE("[Object] RequiredParam Ref<T>") {
CHECK_EQ(ref->get_reference_count(), extract->get_reference_count());
}
TEST_CASE("[Object] RequiredResult") {
Ref<RefCounted> ref;
ref.instantiate();
RequiredResult<RefCounted> required = ref;
Ref<RefCounted> unpacked = required;
Variant var = Ref<RefCounted>(required);
CHECK_EQ(ref, unpacked);
CHECK_EQ(ref, var);
}
} // namespace TestObject

2
tests/scene/test_split_container.h
View File

@@ -1783,7 +1783,7 @@ TEST_CASE("[SceneTree][SplitContainer] More children") {
SUBCASE("[SplitContainer] Duplicate") {
// Make sure dynamically added internal draggers duplicate properly.
SplitContainer *duplicate = (SplitContainer *)split_container->duplicate();
SplitContainer *duplicate = (SplitContainer *)(Node *)split_container->duplicate();
MessageQueue::get_singleton()->flush();
CHECK(duplicate->get_child_count(false) == split_container->get_child_count(false));
CHECK(duplicate->get_child_count(true) == split_container->get_child_count(true));

2
tests/scene/test_viewport.h
View File

@@ -291,7 +291,7 @@ TEST_CASE("[SceneTree][Viewport] Controls and InputEvent handling") {
SUBCASE("[Viewport][GuiInputEvent] nullptr as argument doesn't lead to a crash.") {
ERR_PRINT_OFF;
root->push_input(nullptr);
root->push_input(Ref<InputEvent>());
ERR_PRINT_ON;
}