godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-24 15:26:15 +00:00
Code Releases Wiki Activity

Revert "Add missing SNAME macro optimization to all theme methods call"

Browse Source 
This reverts commit a988fad9a0.

As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used
everywhere but only in critical code paths. For theme methods specifically, it
was by design that only getters use `SNAME` and not setters.
This commit is contained in:
Rémi Verschelde
2022-02-08 10:14:58 +01:00
parent 0154ce2c8d
commit fc076ece3d
90 changed files with 1648 additions and 1648 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
scene/gui/file_dialog.cpp
View File

@@ -65,30 +65,30 @@ void FileDialog::_theme_changed() {
Color font_focus_color = vbox->get_theme_color(SNAME("font_focus_color"), SNAME("Button"));
Color font_pressed_color = vbox->get_theme_color(SNAME("font_pressed_color"), SNAME("Button"));
dir_up->add_theme_color_override(SNAME("icon_normal_color"), font_color);
dir_up->add_theme_color_override(SNAME("icon_hover_color"), font_hover_color);
dir_up->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
dir_up->add_theme_color_override(SNAME("icon_pressed_color"), font_pressed_color);
dir_up->add_theme_color_override("icon_normal_color", font_color);
dir_up->add_theme_color_override("icon_hover_color", font_hover_color);
dir_up->add_theme_color_override("icon_focus_color", font_focus_color);
dir_up->add_theme_color_override("icon_pressed_color", font_pressed_color);
dir_prev->add_theme_color_override(SNAME("icon_color_normal"), font_color);
dir_prev->add_theme_color_override(SNAME("icon_color_hover"), font_hover_color);
dir_prev->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
dir_prev->add_theme_color_override(SNAME("icon_color_pressed"), font_pressed_color);
dir_prev->add_theme_color_override("icon_color_normal", font_color);
dir_prev->add_theme_color_override("icon_color_hover", font_hover_color);
dir_prev->add_theme_color_override("icon_focus_color", font_focus_color);
dir_prev->add_theme_color_override("icon_color_pressed", font_pressed_color);
dir_next->add_theme_color_override(SNAME("icon_color_normal"), font_color);
dir_next->add_theme_color_override(SNAME("icon_color_hover"), font_hover_color);
dir_next->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
dir_next->add_theme_color_override(SNAME("icon_color_pressed"), font_pressed_color);
dir_next->add_theme_color_override("icon_color_normal", font_color);
dir_next->add_theme_color_override("icon_color_hover", font_hover_color);
dir_next->add_theme_color_override("icon_focus_color", font_focus_color);
dir_next->add_theme_color_override("icon_color_pressed", font_pressed_color);
refresh->add_theme_color_override(SNAME("icon_normal_color"), font_color);
refresh->add_theme_color_override(SNAME("icon_hover_color"), font_hover_color);
refresh->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
refresh->add_theme_color_override(SNAME("icon_pressed_color"), font_pressed_color);
refresh->add_theme_color_override("icon_normal_color", font_color);
refresh->add_theme_color_override("icon_hover_color", font_hover_color);
refresh->add_theme_color_override("icon_focus_color", font_focus_color);
refresh->add_theme_color_override("icon_pressed_color", font_pressed_color);
show_hidden->add_theme_color_override(SNAME("icon_normal_color"), font_color);
show_hidden->add_theme_color_override(SNAME("icon_hover_color"), font_hover_color);
show_hidden->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
show_hidden->add_theme_color_override(SNAME("icon_pressed_color"), font_pressed_color);
show_hidden->add_theme_color_override("icon_normal_color", font_color);
show_hidden->add_theme_color_override("icon_hover_color", font_hover_color);
show_hidden->add_theme_color_override("icon_focus_color", font_focus_color);
show_hidden->add_theme_color_override("icon_pressed_color", font_pressed_color);
}
void FileDialog::_notification(int p_what) {