godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

C#: Ensure native handles are freed after switch to .NET Core

Browse Source 
Finalizers are longer guaranteed to be called on exit now that
we switched to .NET Core. This results in native instances leaking.

The only solution I can think of so far is to keep a list of all
instances alive to dispose when the AssemblyLoadContext.Unloading
event is raised.
This commit is contained in:
Ignacio Roldán Etcheverry
2021-12-28 23:25:16 +01:00
parent 4d710bf659
commit f88d8902cf
15 changed files with 185 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
modules/mono/mono_gd/gd_mono.cpp
View File

@@ -471,26 +471,17 @@ GDMono::GDMono() {
}
GDMono::~GDMono() {
finalizing_scripts_domain = true;
if (is_runtime_initialized()) {
#warning "TODO assembly unloading for cleanup of disposables (including managed RefCounteds)"
#if 0
if (scripts_domain) {
Error err = _unload_scripts_domain();
if (err != OK) {
ERR_PRINT("Mono: Failed to unload scripts domain.");
}
if (GDMonoCache::godot_api_cache_updated) {
GDMonoCache::managed_callbacks.DisposablesTracker_OnGodotShuttingDown();
}
print_verbose("Mono: Runtime cleanup...");
mono_jit_cleanup(root_domain);
print_verbose("Mono: Finalized");
#endif
runtime_initialized = false;
}
finalizing_scripts_domain = false;
runtime_initialized = false;
#if defined(ANDROID_ENABLED)
gdmono::android::support::cleanup();
#endif