godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-21 14:57:09 +00:00
Code Releases Wiki Activity

Merge pull request #112770 from KoBeWi/underscore_undercover

Browse Source 
Don't expose underscored signals
This commit is contained in:
Thaddeus Crews
2025-11-17 19:36:07 -06:00
parent 68410acc61 54c2eaee4d
commit f41c8464cc
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
editor/doc/doc_tools.cpp
View File

@@ -660,6 +660,10 @@ void DocTools::generate(BitField<GenerateFlags> p_flags) {
if (signal_list.size()) { if (signal_list.size()) {
for (const MethodInfo &mi : signal_list) { for (const MethodInfo &mi : signal_list) {
if (mi.name.is_empty() || mi.name[0] == '_') {
continue; // Hidden, don't count.
}
DocData::MethodDoc signal; DocData::MethodDoc signal;
signal.name = mi.name; signal.name = mi.name;
for (const PropertyInfo &arginfo : mi.arguments) { for (const PropertyInfo &arginfo : mi.arguments) {

6
modules/gdscript/gdscript_editor.cpp
View File

@@ -1290,6 +1290,9 @@ static void _find_identifiers_in_base(const GDScriptCompletionIdentifier &p_base
List<MethodInfo> signals; List<MethodInfo> signals;
scr->get_script_signal_list(&signals); scr->get_script_signal_list(&signals);
for (const MethodInfo &E : signals) { for (const MethodInfo &E : signals) {
if (E.name.begins_with("_")) {
continue;
}
int location = p_recursion_depth + _get_signal_location(scr, E.name); int location = p_recursion_depth + _get_signal_location(scr, E.name);
ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location); ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location);
r_result.insert(option.display, option); r_result.insert(option.display, option);
@@ -1383,6 +1386,9 @@ static void _find_identifiers_in_base(const GDScriptCompletionIdentifier &p_base
List<MethodInfo> signals; List<MethodInfo> signals;
ClassDB::get_signal_list(type, &signals); ClassDB::get_signal_list(type, &signals);
for (const MethodInfo &E : signals) { for (const MethodInfo &E : signals) {
if (E.name.begins_with("_")) {
continue;
}
int location = p_recursion_depth + _get_signal_location(type, StringName(E.name)); int location = p_recursion_depth + _get_signal_location(type, StringName(E.name));
ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location); ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location);
r_result.insert(option.display, option); r_result.insert(option.display, option);