godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-02 16:48:55 +00:00
Code Releases Wiki Activity

Mono: Fix detection of MsBuild from Visual Studio

Browse Source 
This was a wrong check as an exit code of 0 means success,
not failure. It used to be fine as blocking mode always returned
-2, but this was changed in #32033 to return the exit code.

Fixes #32424.
This commit is contained in:
Rémi Verschelde
2019-10-03 14:11:21 +02:00
parent d66cce0215
commit f3f2fdfbab
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/mono/editor/GodotTools/GodotTools/Build/MsBuildFinder.cs
View File

@@ -34,7 +34,7 @@ namespace GodotTools.Build
if (_msbuildToolsPath.Empty()) if (_msbuildToolsPath.Empty())
{ {
throw new FileNotFoundException($"Cannot find executable for '{BuildManager.PropNameMsbuildVs}'. Tried with path: {_msbuildToolsPath}"); throw new FileNotFoundException($"Cannot find executable for '{BuildManager.PropNameMsbuildVs}'.");
} }
} }
@@ -142,7 +142,7 @@ namespace GodotTools.Build
int exitCode = Godot.OS.Execute(vsWherePath, vsWhereArgs, int exitCode = Godot.OS.Execute(vsWherePath, vsWhereArgs,
blocking: true, output: (Godot.Collections.Array) outputArray); blocking: true, output: (Godot.Collections.Array) outputArray);
if (exitCode == 0) if (exitCode != 0)
return string.Empty; return string.Empty;
if (outputArray.Count == 0) if (outputArray.Count == 0)