godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-07 12:30:27 +00:00
Code Releases Wiki Activity

found via cppcheck:

Browse Source 
remove code that will never run
make definition and declaration names for parameters match
change floats that were being set to bool values
remove pointer that is never used
This commit is contained in:
firefly2442
2018-01-03 21:17:30 -07:00
parent 914f51031c
commit f066991aa7
7 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/os/dir_access.cpp
View File

@@ -293,7 +293,7 @@ String DirAccess::get_full_path(const String &p_path, AccessType p_access) {
return full;
}
Error DirAccess::copy(String p_from, String p_to, int chmod_flags) {
Error DirAccess::copy(String p_from, String p_to, int p_chmod_flags) {
//printf("copy %s -> %s\n",p_from.ascii().get_data(),p_to.ascii().get_data());
Error err;
@@ -330,9 +330,9 @@ Error DirAccess::copy(String p_from, String p_to, int chmod_flags) {
fdst->store_8(fsrc->get_8());
}
if (err == OK && chmod_flags != -1) {
if (err == OK && p_chmod_flags != -1) {
fdst->close();
err = fdst->_chmod(p_to, chmod_flags);
err = fdst->_chmod(p_to, p_chmod_flags);
// If running on a platform with no chmod support (i.e., Windows), don't fail
if (err == ERR_UNAVAILABLE)
err = OK;