godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-24 15:26:15 +00:00
Code Releases Wiki Activity

Prevent setting too big or too small Collision Mask and Layer

Browse Source
This commit is contained in:
Rafał Mikrut
2021-04-30 17:19:04 +02:00
parent 66f696c2c1
commit efcb097674
14 changed files with 48 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/csg/csg_shape.cpp
View File

@@ -89,6 +89,7 @@ uint32_t CSGShape3D::get_collision_mask() const {
} }
void CSGShape3D::set_collision_mask_bit(int p_bit, bool p_value) { void CSGShape3D::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -99,20 +100,23 @@ void CSGShape3D::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool CSGShape3D::get_collision_mask_bit(int p_bit) const { bool CSGShape3D::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }
void CSGShape3D::set_collision_layer_bit(int p_bit, bool p_value) { void CSGShape3D::set_collision_layer_bit(int p_bit, bool p_value) {
uint32_t mask = get_collision_layer(); ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision layer bit must be between 0 and 31 inclusive.");
uint32_t layer = get_collision_layer();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; layer |= 1 << p_bit;
} else { } else {
mask &= ~(1 << p_bit); layer &= ~(1 << p_bit);
} }
set_collision_layer(mask); set_collision_layer(layer);
} }
bool CSGShape3D::get_collision_layer_bit(int p_bit) const { bool CSGShape3D::get_collision_layer_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision layer bit must be between 0 and 31 inclusive.");
return get_collision_layer() & (1 << p_bit); return get_collision_layer() & (1 << p_bit);
} }

12
modules/gridmap/grid_map.cpp
View File

@@ -152,6 +152,7 @@ uint32_t GridMap::get_collision_mask() const {
} }
void GridMap::set_collision_mask_bit(int p_bit, bool p_value) { void GridMap::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -162,20 +163,23 @@ void GridMap::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool GridMap::get_collision_mask_bit(int p_bit) const { bool GridMap::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }
void GridMap::set_collision_layer_bit(int p_bit, bool p_value) { void GridMap::set_collision_layer_bit(int p_bit, bool p_value) {
uint32_t mask = get_collision_layer(); ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision layer bit must be between 0 and 31 inclusive.");
uint32_t layer = get_collision_layer();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; layer |= 1 << p_bit;
} else { } else {
mask &= ~(1 << p_bit); layer &= ~(1 << p_bit);
} }
set_collision_layer(mask); set_collision_layer(layer);
} }
bool GridMap::get_collision_layer_bit(int p_bit) const { bool GridMap::get_collision_layer_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision layer bit must be between 0 and 31 inclusive.");
return get_collision_layer() & (1 << p_bit); return get_collision_layer() & (1 << p_bit);
} }

4
scene/2d/collision_object_2d.cpp
View File

@@ -127,6 +127,7 @@ uint32_t CollisionObject2D::get_collision_mask() const {
} }
void CollisionObject2D::set_collision_layer_bit(int p_bit, bool p_value) { void CollisionObject2D::set_collision_layer_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision layer bit must be between 0 and 31 inclusive.");
uint32_t collision_layer = get_collision_layer(); uint32_t collision_layer = get_collision_layer();
if (p_value) { if (p_value) {
collision_layer |= 1 << p_bit; collision_layer |= 1 << p_bit;
@@ -137,10 +138,12 @@ void CollisionObject2D::set_collision_layer_bit(int p_bit, bool p_value) {
} }
bool CollisionObject2D::get_collision_layer_bit(int p_bit) const { bool CollisionObject2D::get_collision_layer_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision layer bit must be between 0 and 31 inclusive.");
return get_collision_layer() & (1 << p_bit); return get_collision_layer() & (1 << p_bit);
} }
void CollisionObject2D::set_collision_mask_bit(int p_bit, bool p_value) { void CollisionObject2D::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -151,6 +154,7 @@ void CollisionObject2D::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool CollisionObject2D::get_collision_mask_bit(int p_bit) const { bool CollisionObject2D::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }

2
scene/2d/ray_cast_2d.cpp
View File

@@ -55,6 +55,7 @@ uint32_t RayCast2D::get_collision_mask() const {
} }
void RayCast2D::set_collision_mask_bit(int p_bit, bool p_value) { void RayCast2D::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -65,6 +66,7 @@ void RayCast2D::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool RayCast2D::get_collision_mask_bit(int p_bit) const { bool RayCast2D::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }

4
scene/2d/tile_map.cpp
View File

@@ -1250,6 +1250,7 @@ void TileMap::set_collision_mask(uint32_t p_mask) {
} }
void TileMap::set_collision_layer_bit(int p_bit, bool p_value) { void TileMap::set_collision_layer_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision layer bit must be between 0 and 31 inclusive.");
uint32_t layer = get_collision_layer(); uint32_t layer = get_collision_layer();
if (p_value) { if (p_value) {
layer |= 1 << p_bit; layer |= 1 << p_bit;
@@ -1260,6 +1261,7 @@ void TileMap::set_collision_layer_bit(int p_bit, bool p_value) {
} }
void TileMap::set_collision_mask_bit(int p_bit, bool p_value) { void TileMap::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -1352,10 +1354,12 @@ uint32_t TileMap::get_collision_mask() const {
} }
bool TileMap::get_collision_layer_bit(int p_bit) const { bool TileMap::get_collision_layer_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision layer bit must be between 0 and 31 inclusive.");
return get_collision_layer() & (1 << p_bit); return get_collision_layer() & (1 << p_bit);
} }
bool TileMap::get_collision_mask_bit(int p_bit) const { bool TileMap::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }

2
scene/3d/camera_3d.cpp
View File

@@ -761,6 +761,7 @@ uint32_t ClippedCamera3D::get_collision_mask() const {
} }
void ClippedCamera3D::set_collision_mask_bit(int p_bit, bool p_value) { void ClippedCamera3D::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision layer bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -771,6 +772,7 @@ void ClippedCamera3D::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool ClippedCamera3D::get_collision_mask_bit(int p_bit) const { bool ClippedCamera3D::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }

4
scene/3d/collision_object_3d.cpp
View File

@@ -110,6 +110,7 @@ uint32_t CollisionObject3D::get_collision_mask() const {
} }
void CollisionObject3D::set_collision_layer_bit(int p_bit, bool p_value) { void CollisionObject3D::set_collision_layer_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision layer bit must be between 0 and 31 inclusive.");
uint32_t collision_layer = get_collision_layer(); uint32_t collision_layer = get_collision_layer();
if (p_value) { if (p_value) {
collision_layer |= 1 << p_bit; collision_layer |= 1 << p_bit;
@@ -120,10 +121,12 @@ void CollisionObject3D::set_collision_layer_bit(int p_bit, bool p_value) {
} }
bool CollisionObject3D::get_collision_layer_bit(int p_bit) const { bool CollisionObject3D::get_collision_layer_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision layer bit must be between 0 and 31 inclusive.");
return get_collision_layer() & (1 << p_bit); return get_collision_layer() & (1 << p_bit);
} }
void CollisionObject3D::set_collision_mask_bit(int p_bit, bool p_value) { void CollisionObject3D::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -134,6 +137,7 @@ void CollisionObject3D::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool CollisionObject3D::get_collision_mask_bit(int p_bit) const { bool CollisionObject3D::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }

2
scene/3d/ray_cast_3d.cpp
View File

@@ -61,6 +61,7 @@ uint32_t RayCast3D::get_collision_mask() const {
} }
void RayCast3D::set_collision_mask_bit(int p_bit, bool p_value) { void RayCast3D::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -71,6 +72,7 @@ void RayCast3D::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool RayCast3D::get_collision_mask_bit(int p_bit) const { bool RayCast3D::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }

4
scene/3d/soft_body_3d.cpp
View File

@@ -496,6 +496,7 @@ uint32_t SoftBody3D::get_collision_layer() const {
} }
void SoftBody3D::set_collision_mask_bit(int p_bit, bool p_value) { void SoftBody3D::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -506,10 +507,12 @@ void SoftBody3D::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool SoftBody3D::get_collision_mask_bit(int p_bit) const { bool SoftBody3D::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }
void SoftBody3D::set_collision_layer_bit(int p_bit, bool p_value) { void SoftBody3D::set_collision_layer_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision layer bit must be between 0 and 31 inclusive.");
uint32_t layer = get_collision_layer(); uint32_t layer = get_collision_layer();
if (p_value) { if (p_value) {
layer |= 1 << p_bit; layer |= 1 << p_bit;
@@ -520,6 +523,7 @@ void SoftBody3D::set_collision_layer_bit(int p_bit, bool p_value) {
} }
bool SoftBody3D::get_collision_layer_bit(int p_bit) const { bool SoftBody3D::get_collision_layer_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision layer bit must be between 0 and 31 inclusive.");
return get_collision_layer() & (1 << p_bit); return get_collision_layer() & (1 << p_bit);
} }

2
scene/resources/navigation_mesh.cpp
View File

@@ -92,6 +92,7 @@ uint32_t NavigationMesh::get_collision_mask() const {
} }
void NavigationMesh::set_collision_mask_bit(int p_bit, bool p_value) { void NavigationMesh::set_collision_mask_bit(int p_bit, bool p_value) {
ERR_FAIL_INDEX_MSG(p_bit, 32, "Collision mask bit must be between 0 and 31 inclusive.");
uint32_t mask = get_collision_mask(); uint32_t mask = get_collision_mask();
if (p_value) { if (p_value) {
mask |= 1 << p_bit; mask |= 1 << p_bit;
@@ -102,6 +103,7 @@ void NavigationMesh::set_collision_mask_bit(int p_bit, bool p_value) {
} }
bool NavigationMesh::get_collision_mask_bit(int p_bit) const { bool NavigationMesh::get_collision_mask_bit(int p_bit) const {
ERR_FAIL_INDEX_V_MSG(p_bit, 32, false, "Collision mask bit must be between 0 and 31 inclusive.");
return get_collision_mask() & (1 << p_bit); return get_collision_mask() & (1 << p_bit);
} }

4
servers/physics_server_2d.cpp
View File

@@ -176,11 +176,11 @@ real_t PhysicsShapeQueryParameters2D::get_margin() const {
return margin; return margin;
} }
void PhysicsShapeQueryParameters2D::set_collision_mask(int p_collision_mask) { void PhysicsShapeQueryParameters2D::set_collision_mask(uint32_t p_collision_mask) {
collision_mask = p_collision_mask; collision_mask = p_collision_mask;
} }
int PhysicsShapeQueryParameters2D::get_collision_mask() const { uint32_t PhysicsShapeQueryParameters2D::get_collision_mask() const {
return collision_mask; return collision_mask;
} }

4
servers/physics_server_2d.h
View File

@@ -128,8 +128,8 @@ public:
void set_margin(real_t p_margin); void set_margin(real_t p_margin);
real_t get_margin() const; real_t get_margin() const;
void set_collision_mask(int p_collision_mask); void set_collision_mask(uint32_t p_mask);
int get_collision_mask() const; uint32_t get_collision_mask() const;
void set_collide_with_bodies(bool p_enable); void set_collide_with_bodies(bool p_enable);
bool is_collide_with_bodies_enabled() const; bool is_collide_with_bodies_enabled() const;

4
servers/physics_server_3d.cpp
View File

@@ -172,11 +172,11 @@ real_t PhysicsShapeQueryParameters3D::get_margin() const {
return margin; return margin;
} }
void PhysicsShapeQueryParameters3D::set_collision_mask(int p_collision_mask) { void PhysicsShapeQueryParameters3D::set_collision_mask(uint32_t p_collision_mask) {
collision_mask = p_collision_mask; collision_mask = p_collision_mask;
} }
int PhysicsShapeQueryParameters3D::get_collision_mask() const { uint32_t PhysicsShapeQueryParameters3D::get_collision_mask() const {
return collision_mask; return collision_mask;
} }

4
servers/physics_server_3d.h
View File

@@ -125,8 +125,8 @@ public:
void set_margin(real_t p_margin); void set_margin(real_t p_margin);
real_t get_margin() const; real_t get_margin() const;
void set_collision_mask(int p_collision_mask); void set_collision_mask(uint32_t p_collision_mask);
int get_collision_mask() const; uint32_t get_collision_mask() const;
void set_exclude(const Vector<RID> &p_exclude); void set_exclude(const Vector<RID> &p_exclude);
Vector<RID> get_exclude() const; Vector<RID> get_exclude() const;