godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

Merge pull request #65624 from KoBeWi/help_I'm_stuck

Browse Source 
Prevent infinite loops in editor help search
This commit is contained in:
Rémi Verschelde
2022-09-13 10:58:25 +02:00
parent 5c1ef35def 7fc075d235
commit ecefae22cb
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
editor/editor_help_search.cpp
View File

@@ -326,6 +326,7 @@ bool EditorHelpSearch::Runner::_phase_match_classes_init() {
bool EditorHelpSearch::Runner::_phase_match_classes() { bool EditorHelpSearch::Runner::_phase_match_classes() {
DocData::ClassDoc &class_doc = iterator_doc->value; DocData::ClassDoc &class_doc = iterator_doc->value;
if (class_doc.name.is_empty()) { if (class_doc.name.is_empty()) {
++iterator_doc;
return false; return false;
} }
if (!_is_class_disabled_by_feature_profile(class_doc.name)) { if (!_is_class_disabled_by_feature_profile(class_doc.name)) {
@@ -432,7 +433,7 @@ bool EditorHelpSearch::Runner::_phase_class_items_init() {
bool EditorHelpSearch::Runner::_phase_class_items() { bool EditorHelpSearch::Runner::_phase_class_items() {
if (!iterator_match) { if (!iterator_match) {
return false; return true;
} }
ClassMatch &match = iterator_match->value; ClassMatch &match = iterator_match->value;
@@ -459,10 +460,8 @@ bool EditorHelpSearch::Runner::_phase_member_items_init() {
bool EditorHelpSearch::Runner::_phase_member_items() { bool EditorHelpSearch::Runner::_phase_member_items() {
ClassMatch &match = iterator_match->value; ClassMatch &match = iterator_match->value;
if (!match.doc) { if (!match.doc || match.doc->name.is_empty()) {
return false; ++iterator_match;
}
if (match.doc->name.is_empty()) {
return false; return false;
} }