godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-07 12:30:27 +00:00
Code Releases Wiki Activity

[Core] Fix property access on read-only Dictionary

Browse Source
This commit is contained in:
A Thousand Ships
2024-03-18 15:10:37 +01:00
parent 7529c0bec5
commit ec29c3e784
3 changed files with 23 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
core/variant/variant_setget.cpp
View File

@@ -251,15 +251,21 @@ void Variant::set_named(const StringName &p_member, const Variant &p_value, bool
return;
}
} else if (type == Variant::DICTIONARY) {
Variant *v = VariantGetInternalPtr<Dictionary>::get_ptr(this)->getptr(p_member);
if (v) {
*v = p_value;
r_valid = true;
} else {
VariantGetInternalPtr<Dictionary>::get_ptr(this)->operator[](p_member) = p_value;
r_valid = true;
Dictionary &dict = *VariantGetInternalPtr<Dictionary>::get_ptr(this);
if (dict.is_read_only()) {
r_valid = false;
return;
}
Variant *v = dict.getptr(p_member);
if (v) {
*v = p_value;
} else {
dict[p_member] = p_value;
}
r_valid = true;
} else {
r_valid = false;
}