godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

Don't allow removing TextEdit's main caret

Browse Source
This commit is contained in:
Haoyu Qiu
2022-10-08 20:39:24 +08:00
parent ca25c6e0a3
commit eac9adf7a1
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scene/gui/text_edit.cpp
View File

@@ -4380,7 +4380,7 @@ int TextEdit::add_caret(int p_line, int p_col) {
} }
void TextEdit::remove_caret(int p_caret) { void TextEdit::remove_caret(int p_caret) {
ERR_FAIL_COND(carets.size() <= 0); ERR_FAIL_COND_MSG(carets.size() <= 1, "The main caret should not be removed.");
ERR_FAIL_INDEX(p_caret, carets.size()); ERR_FAIL_INDEX(p_caret, carets.size());
carets.remove_at(p_caret); carets.remove_at(p_caret);
caret_index_edit_dirty = true; caret_index_edit_dirty = true;

5
tests/scene/test_text_edit.h
View File

@@ -3321,6 +3321,11 @@ TEST_CASE("[SceneTree][TextEdit] muiticaret") {
CHECK(text_edit->get_caret_count() == 1); CHECK(text_edit->get_caret_count() == 1);
CHECK(text_edit->get_caret_line(0) == 0); CHECK(text_edit->get_caret_line(0) == 0);
CHECK(text_edit->get_caret_column(0) == 1); CHECK(text_edit->get_caret_column(0) == 1);
ERR_PRINT_OFF;
text_edit->remove_caret(0);
CHECK(text_edit->get_caret_count() == 1);
ERR_PRINT_ON;
} }
SUBCASE("[TextEdit] caret index edit order") { SUBCASE("[TextEdit] caret index edit order") {