godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-14 13:41:12 +00:00
Code Releases Wiki Activity

Mono: Fix crash when re-using script binding after domain reloading

Browse Source
This commit is contained in:
Ignacio Etcheverry
2019-03-07 19:55:40 +01:00
parent 5f079e2ef9
commit e904f814c8
3 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/mono/csharp_script.cpp
View File

@@ -985,6 +985,13 @@ bool CSharpLanguage::debug_break(const String &p_error, bool p_allow_continue) {
} }
} }
void CSharpLanguage::_uninitialize_script_bindings() {
for (Map<Object *, CSharpScriptBinding>::Element *E = script_bindings.front(); E; E = E->next()) {
CSharpScriptBinding &script_binding = E->value();
script_binding.inited = false;
}
}
void CSharpLanguage::set_language_index(int p_idx) { void CSharpLanguage::set_language_index(int p_idx) {
ERR_FAIL_COND(lang_idx != -1); ERR_FAIL_COND(lang_idx != -1);

3
modules/mono/csharp_script.h
View File

@@ -309,6 +309,9 @@ class CSharpLanguage : public ScriptLanguage {
Dictionary scripts_metadata; Dictionary scripts_metadata;
friend class GDMono;
void _uninitialize_script_bindings();
public: public:
StringNameCache string_names; StringNameCache string_names;

2
modules/mono/mono_gd/gd_mono.cpp
View File

@@ -848,6 +848,8 @@ Error GDMono::reload_scripts_domain() {
} }
} }
CSharpLanguage::get_singleton()->_uninitialize_script_bindings();
Error err = _load_scripts_domain(); Error err = _load_scripts_domain();
if (err != OK) { if (err != OK) {
ERR_PRINT("Mono: Failed to load scripts domain"); ERR_PRINT("Mono: Failed to load scripts domain");