godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-06 12:20:30 +00:00
Code Releases Wiki Activity

Merge pull request #82627 from kleonc/animation-editor-audio-clip-offset-sliders-limit-to-length

Browse Source 
Limit animation audio clip inspector offset sliders to clip length
This commit is contained in:
Rémi Verschelde
2023-10-16 10:38:08 +02:00
parent 897ff71156 c1008c2471
commit e897a46a5f
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
editor/animation_track_editor.cpp
View File

@@ -330,6 +330,7 @@ bool AnimationTrackKeyEdit::_set(const StringName &p_name, const Variant &p_valu
undo_redo->commit_action(); undo_redo->commit_action();
setting = false; setting = false;
notify_change(); // To update limits for `start_offset`/`end_offset` sliders (they depend on the stream length).
return true; return true;
} }
@@ -586,8 +587,10 @@ void AnimationTrackKeyEdit::_get_property_list(List<PropertyInfo> *p_list) const
} break; } break;
case Animation::TYPE_AUDIO: { case Animation::TYPE_AUDIO: {
p_list->push_back(PropertyInfo(Variant::OBJECT, PNAME("stream"), PROPERTY_HINT_RESOURCE_TYPE, "AudioStream")); p_list->push_back(PropertyInfo(Variant::OBJECT, PNAME("stream"), PROPERTY_HINT_RESOURCE_TYPE, "AudioStream"));
p_list->push_back(PropertyInfo(Variant::FLOAT, PNAME("start_offset"), PROPERTY_HINT_RANGE, "0,3600,0.0001,or_greater")); Ref<AudioStream> audio_stream = animation->audio_track_get_key_stream(track, key);
p_list->push_back(PropertyInfo(Variant::FLOAT, PNAME("end_offset"), PROPERTY_HINT_RANGE, "0,3600,0.0001,or_greater")); String hint_string = vformat("0,%.4f,0.0001,or_greater", audio_stream.is_valid() ? audio_stream->get_length() : 3600.0);
p_list->push_back(PropertyInfo(Variant::FLOAT, PNAME("start_offset"), PROPERTY_HINT_RANGE, hint_string));
p_list->push_back(PropertyInfo(Variant::FLOAT, PNAME("end_offset"), PROPERTY_HINT_RANGE, hint_string));
} break; } break;
case Animation::TYPE_ANIMATION: { case Animation::TYPE_ANIMATION: {