godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-08 12:40:44 +00:00
Code Releases Wiki Activity

Make warning about Reference singletons more accurate

Browse Source
This commit is contained in:
Pedro J. Estébanez
2020-11-23 10:42:44 +01:00
parent a248e6f8c3
commit e79162ec4e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/config/engine.cpp
View File

@@ -224,8 +224,9 @@ Engine::Singleton::Singleton(const StringName &p_name, Object *p_ptr) :
name(p_name), name(p_name),
ptr(p_ptr) { ptr(p_ptr) {
#ifdef DEBUG_ENABLED #ifdef DEBUG_ENABLED
if (Object::cast_to<Reference>(p_ptr)) { Reference *ref = Object::cast_to<Reference>(p_ptr);
ERR_PRINT("A class intended to be used as a singleton must *not* inherit from Reference."); if (ref && !ref->is_referenced()) {
WARN_PRINT("You must use Ref<> to ensure the lifetime of a Reference object intended to be used as a singleton.");
} }
#endif #endif
} }