godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

Replace CreateThread with QueueUserWorkItem

Browse Source 
Fixes #24869 stuttering on Windows by reusing long running threadpool threads instead of creating a new thread on each call to Thread::start.
This commit is contained in:
Marcin Zawiejski
2019-01-19 00:31:10 +01:00
committed by GitHub
parent 73a7a1a388
commit e65bce3083
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/windows/thread_windows.cpp
View File

@@ -52,6 +52,7 @@ DWORD ThreadWindows::thread_callback(LPVOID userdata) {
t->id = (ID)GetCurrentThreadId(); // must implement t->id = (ID)GetCurrentThreadId(); // must implement
t->callback(t->user); t->callback(t->user);
SetEvent(t->handle);
ScriptServer::thread_exit(); ScriptServer::thread_exit();
@@ -63,13 +64,9 @@ Thread *ThreadWindows::create_func_windows(ThreadCreateCallback p_callback, void
ThreadWindows *tr = memnew(ThreadWindows); ThreadWindows *tr = memnew(ThreadWindows);
tr->callback = p_callback; tr->callback = p_callback;
tr->user = p_user; tr->user = p_user;
tr->handle = CreateThread( tr->handle = CreateEvent(NULL, TRUE, FALSE, NULL);
NULL, // default security attributes
0, // use default stack size QueueUserWorkItem(thread_callback, tr, WT_EXECUTELONGFUNCTION);
thread_callback, // thread function name
tr, // argument to thread function
0, // use default creation flags
NULL); // returns the thread identifier
return tr; return tr;
} }