godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

Fix some bugs spotted by asan in editor debugger.

Browse Source 
EditorDebuggerInspector is in tree, so it gets automatically deleted,
when clearing errors the debugger should not fake a process
notification.
This commit is contained in:
Fabio Alessandrelli
2020-03-05 12:24:49 +01:00
parent e8b68c48ea
commit e5ec499a92
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
editor/debugger/editor_debugger_inspector.cpp
View File

@@ -91,6 +91,7 @@ EditorDebuggerInspector::EditorDebuggerInspector() {
} }
EditorDebuggerInspector::~EditorDebuggerInspector() { EditorDebuggerInspector::~EditorDebuggerInspector() {
clear_cache();
memdelete(variables); memdelete(variables);
} }

4
editor/debugger/script_editor_debugger.cpp
View File

@@ -1423,7 +1423,7 @@ void ScriptEditorDebugger::_clear_errors_list() {
error_tree->clear(); error_tree->clear();
error_count = 0; error_count = 0;
warning_count = 0; warning_count = 0;
_notification(NOTIFICATION_PROCESS); update_tabs();
} }
// Right click on specific file(s) or folder(s). // Right click on specific file(s) or folder(s).
@@ -1834,7 +1834,5 @@ ScriptEditorDebugger::ScriptEditorDebugger(EditorNode *p_editor) {
ScriptEditorDebugger::~ScriptEditorDebugger() { ScriptEditorDebugger::~ScriptEditorDebugger() {
ppeer->set_stream_peer(Ref<StreamPeer>()); ppeer->set_stream_peer(Ref<StreamPeer>());
inspector->clear_cache();
memdelete(scene_tree); memdelete(scene_tree);
} }