godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-02 16:48:55 +00:00
Code Releases Wiki Activity

Fix SplitContainer crash on change type

Browse Source
This commit is contained in:
kit
2025-11-25 16:10:08 -05:00
parent 9dd6c4dbac
commit e4e00a5461
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scene/gui/split_container.cpp
View File

@@ -750,7 +750,7 @@ void SplitContainer::_resort() {
void SplitContainer::_update_draggers() { void SplitContainer::_update_draggers() {
const int valid_child_count = (int)valid_children.size(); const int valid_child_count = (int)valid_children.size();
const int dragger_count = valid_child_count - 1; const int dragger_count = MAX(valid_child_count - 1, 1);
const int draggers_size_diff = dragger_count - (int)dragging_area_controls.size(); const int draggers_size_diff = dragger_count - (int)dragging_area_controls.size();
// Add new draggers. // Add new draggers.
@@ -768,7 +768,10 @@ void SplitContainer::_update_draggers() {
const int remove_at = (int)dragging_area_controls.size() - 1; const int remove_at = (int)dragging_area_controls.size() - 1;
SplitContainerDragger *dragger = dragging_area_controls[remove_at]; SplitContainerDragger *dragger = dragging_area_controls[remove_at];
dragging_area_controls.remove_at(remove_at); dragging_area_controls.remove_at(remove_at);
remove_child(dragger); // replace_by removes all children, so make sure it is a child before removing.
if (dragger->get_parent() == this) {
remove_child(dragger);
}
memdelete(dragger); memdelete(dragger);
} }