godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

Allow running EditorScripts from the FileSystemDock

Browse Source 
Apply suggestions from code review

Co-Authored-By: Tomasz Chabora <kobewi4e@gmail.com>
This commit is contained in:
Ryan
2025-05-13 02:07:26 -04:00
parent db66343528
commit e3db0d62a8
5 changed files with 57 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
editor/plugins/script_editor_plugin.cpp
View File

@@ -1491,36 +1491,7 @@ void ScriptEditor::_menu_option(int p_option) {
current->apply_code();
Error err = scr->reload(true); // Always hard reload the script before running.
if (err != OK || !scr->is_valid()) {
EditorToaster::get_singleton()->popup_str(TTR("Cannot run the script because it contains errors, check the output log."), EditorToaster::SEVERITY_WARNING);
return;
}
// Perform additional checks on the script to evaluate if it's runnable.
bool is_runnable = true;
if (!ClassDB::is_parent_class(scr->get_instance_base_type(), "EditorScript")) {
is_runnable = false;
EditorToaster::get_singleton()->popup_str(TTR("Cannot run the script because it doesn't extend EditorScript."), EditorToaster::SEVERITY_WARNING);
}
if (!scr->is_tool()) {
is_runnable = false;
if (scr->get_class() == "GDScript") {
EditorToaster::get_singleton()->popup_str(TTR("Cannot run the script because it's not a tool script (add the @tool annotation at the top)."), EditorToaster::SEVERITY_WARNING);
} else {
EditorToaster::get_singleton()->popup_str(TTR("Cannot run the script because it's not a tool script."), EditorToaster::SEVERITY_WARNING);
}
}
if (!is_runnable) {
return;
}
Ref<EditorScript> es = memnew(EditorScript);
es->set_script(scr);
es->run();
EditorNode::get_singleton()->run_editor_script(scr);
} break;
case FILE_MENU_CLOSE: {