godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

Add check to validate client IDs in ENet.

Browse Source 
Server now checks that the ID received from the client is not already
used by someone else and is a valid ID (>=2)
This commit is contained in:
Fabio Alessandrelli
2019-02-20 16:28:53 +01:00
parent d39c0577c0
commit dc583a6225
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/enet/networked_multiplayer_enet.cpp
View File

@@ -231,6 +231,13 @@ void NetworkedMultiplayerENet::poll() {
break; break;
} }
// A client joined with an invalid ID (neagtive values, 0, and 1 are reserved).
// Probably trying to exploit us.
if (server && ((int)event.data < 2 || peer_map.has((int)event.data))) {
enet_peer_reset(event.peer);
ERR_CONTINUE(true);
}
int *new_id = memnew(int); int *new_id = memnew(int);
*new_id = event.data; *new_id = event.data;