godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Get rid of easily removable uses of const_cast

Browse Source
This commit is contained in:
rune-scape
2024-07-29 21:23:12 -07:00
committed by rune-scape
parent 893bbdfde8
commit d58b2e879f
69 changed files with 342 additions and 306 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
scene/3d/skeleton_3d.cpp
View File

@@ -236,7 +236,7 @@ void Skeleton3D::_validate_property(PropertyInfo &p_property) const {
}
}
void Skeleton3D::_update_process_order() {
void Skeleton3D::_update_process_order() const {
if (!process_order_dirty) {
return;
}
@@ -280,7 +280,7 @@ void Skeleton3D::_update_process_order() {
process_order_dirty = false;
emit_signal("bone_list_changed");
const_cast<Skeleton3D *>(this)->emit_signal("bone_list_changed");
}
void Skeleton3D::_update_bone_names() const {
@@ -468,7 +468,7 @@ void Skeleton3D::_make_modifiers_dirty() {
_update_deferred(UPDATE_FLAG_MODIFIER);
}
void Skeleton3D::_update_bones_nested_set() {
void Skeleton3D::_update_bones_nested_set() const {
nested_set_offset_to_bone_index.resize(bones.size());
bone_global_pose_dirty.resize(bones.size());
_make_bone_global_poses_dirty();
@@ -479,7 +479,7 @@ void Skeleton3D::_update_bones_nested_set() {
}
}
int Skeleton3D::_update_bone_nested_set(int p_bone, int p_offset) {
int Skeleton3D::_update_bone_nested_set(int p_bone, int p_offset) const {
Bone &bone = bones[p_bone];
int offset = p_offset + 1;
int span = 1;
@@ -497,13 +497,13 @@ int Skeleton3D::_update_bone_nested_set(int p_bone, int p_offset) {
return span;
}
void Skeleton3D::_make_bone_global_poses_dirty() {
void Skeleton3D::_make_bone_global_poses_dirty() const {
for (uint32_t i = 0; i < bone_global_pose_dirty.size(); i++) {
bone_global_pose_dirty[i] = true;
}
}
void Skeleton3D::_make_bone_global_pose_subtree_dirty(int p_bone) {
void Skeleton3D::_make_bone_global_pose_subtree_dirty(int p_bone) const {
if (process_order_dirty) {
return;
}
@@ -522,7 +522,7 @@ void Skeleton3D::_make_bone_global_pose_subtree_dirty(int p_bone) {
}
}
void Skeleton3D::_update_bone_global_pose(int p_bone) {
void Skeleton3D::_update_bone_global_pose(int p_bone) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX(p_bone, bone_size);
@@ -572,7 +572,7 @@ void Skeleton3D::_update_bone_global_pose(int p_bone) {
Transform3D Skeleton3D::get_bone_global_pose(int p_bone) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX_V(p_bone, bone_size, Transform3D());
const_cast<Skeleton3D *>(this)->_update_bone_global_pose(p_bone);
_update_bone_global_pose(p_bone);
return bones[p_bone].global_pose;
}
@@ -756,7 +756,7 @@ int Skeleton3D::get_bone_parent(int p_bone) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX_V(p_bone, bone_size, -1);
if (process_order_dirty) {
const_cast<Skeleton3D *>(this)->_update_process_order();
_update_process_order();
}
return bones[p_bone].parent;
}
@@ -765,14 +765,14 @@ Vector<int> Skeleton3D::get_bone_children(int p_bone) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX_V(p_bone, bone_size, Vector<int>());
if (process_order_dirty) {
const_cast<Skeleton3D *>(this)->_update_process_order();
_update_process_order();
}
return bones[p_bone].child_bones;
}
Vector<int> Skeleton3D::get_parentless_bones() const {
if (process_order_dirty) {
const_cast<Skeleton3D *>(this)->_update_process_order();
_update_process_order();
}
return parentless_bones;
}
@@ -796,7 +796,7 @@ Transform3D Skeleton3D::get_bone_global_rest(int p_bone) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX_V(p_bone, bone_size, Transform3D());
if (rest_dirty) {
const_cast<Skeleton3D *>(this)->force_update_all_bone_transforms();
_force_update_all_bone_transforms();
}
return bones[p_bone].global_rest;
}
@@ -921,7 +921,7 @@ void Skeleton3D::reset_bone_poses() {
Transform3D Skeleton3D::get_bone_pose(int p_bone) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX_V(p_bone, bone_size, Transform3D());
const_cast<Skeleton3D *>(this)->bones[p_bone].update_pose_cache();
bones[p_bone].update_pose_cache();
return bones[p_bone].pose_cache;
}
@@ -1037,20 +1037,28 @@ void Skeleton3D::force_update_deferred() {
}
void Skeleton3D::force_update_all_dirty_bones() {
_force_update_all_dirty_bones();
}
void Skeleton3D::_force_update_all_dirty_bones() const {
if (!dirty) {
return;
}
force_update_all_bone_transforms();
_force_update_all_bone_transforms();
}
void Skeleton3D::force_update_all_bone_transforms() {
_force_update_all_bone_transforms();
}
void Skeleton3D::_force_update_all_bone_transforms() const {
_update_process_order();
for (int i = 0; i < parentless_bones.size(); i++) {
force_update_bone_children_transforms(parentless_bones[i]);
_force_update_bone_children_transforms(parentless_bones[i]);
}
if (rest_dirty) {
rest_dirty = false;
emit_signal(SNAME("rest_updated"));
const_cast<Skeleton3D *>(this)->emit_signal(SNAME("rest_updated"));
} else {
rest_dirty = false;
}
@@ -1058,10 +1066,14 @@ void Skeleton3D::force_update_all_bone_transforms() {
if (updating) {
return;
}
emit_signal(SceneStringName(pose_updated));
const_cast<Skeleton3D *>(this)->emit_signal(SceneStringName(pose_updated));
}
void Skeleton3D::force_update_bone_children_transforms(int p_bone_idx) {
_force_update_bone_children_transforms(p_bone_idx);
}
void Skeleton3D::_force_update_bone_children_transforms(int p_bone_idx) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX(p_bone_idx, bone_size);
@@ -1321,7 +1333,7 @@ Transform3D Skeleton3D::get_bone_global_pose_override(int p_bone) const {
Transform3D Skeleton3D::get_bone_global_pose_no_override(int p_bone) const {
const int bone_size = bones.size();
ERR_FAIL_INDEX_V(p_bone, bone_size, Transform3D());
const_cast<Skeleton3D *>(this)->force_update_all_dirty_bones();
_force_update_all_dirty_bones();
return bones[p_bone].pose_global_no_override;
}