godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-07 12:30:27 +00:00
Code Releases Wiki Activity

Fixes use after free in redo of "Create Custom Bone2D(s) from Node(s)"

Browse Source 
Using "queue_free" on the undo of the creation of the Bone2D meant that on the redo the Bone2D was already deleted.

Replaced it with "add_do_reference", so when the Action of the undo_redo is destroyed, also destroys the Bone2D.
This commit is contained in:
Agustín Marsero
2024-11-28 16:55:18 +01:00
parent 9aed9eca40
commit d514ab2952
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
editor/plugins/canvas_item_editor_plugin.cpp
View File

@@ -4805,11 +4805,12 @@ void CanvasItemEditor::_popup_callback(int p_op) {
undo_redo->add_do_method(new_bone, "add_child", n2d);
undo_redo->add_do_method(n2d, "set_transform", Transform2D());
undo_redo->add_do_method(this, "_set_owner_for_node_and_children", new_bone, editor_root);
undo_redo->add_do_reference(new_bone);
undo_redo->add_undo_method(new_bone, "remove_child", n2d);
undo_redo->add_undo_method(n2d_parent, "add_child", n2d);
undo_redo->add_undo_method(n2d_parent, "remove_child", new_bone);
undo_redo->add_undo_method(n2d, "set_transform", new_bone->get_transform());
undo_redo->add_undo_method(new_bone, "queue_free");
undo_redo->add_undo_method(this, "_set_owner_for_node_and_children", n2d, editor_root);
}
undo_redo->commit_action();