godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-08 12:40:44 +00:00
Code Releases Wiki Activity

Merge pull request #108979 from HolonProduction/completion-call-stack-lambda

Browse Source 
Autocompletion: Push empty call for lambdas
This commit is contained in:
Thaddeus Crews
2025-07-27 10:28:33 -05:00
parent 4927bbf309 926cab9027
commit d4f14aaa78
5 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/gdscript/gdscript_parser.cpp
View File

@@ -3618,6 +3618,8 @@ GDScriptParser::ExpressionNode *GDScriptParser::parse_lambda(ExpressionNode *p_p
bool multiline_context = multiline_stack.back()->get(); bool multiline_context = multiline_stack.back()->get();
push_completion_call(nullptr);
// Reset the multiline stack since we don't want the multiline mode one in the lambda body. // Reset the multiline stack since we don't want the multiline mode one in the lambda body.
push_multiline(false); push_multiline(false);
if (multiline_context) { if (multiline_context) {
@@ -3665,6 +3667,8 @@ GDScriptParser::ExpressionNode *GDScriptParser::parse_lambda(ExpressionNode *p_p
pop_multiline(); pop_multiline();
pop_completion_call();
if (multiline_context) { if (multiline_context) {
// If we're in multiline mode, we want to skip the spurious DEDENT and NEWLINE tokens. // If we're in multiline mode, we want to skip the spurious DEDENT and NEWLINE tokens.
while (check(GDScriptTokenizer::Token::DEDENT) || check(GDScriptTokenizer::Token::INDENT) || check(GDScriptTokenizer::Token::NEWLINE)) { while (check(GDScriptTokenizer::Token::DEDENT) || check(GDScriptTokenizer::Token::INDENT) || check(GDScriptTokenizer::Token::NEWLINE)) {

7
modules/gdscript/tests/scripts/completion/no_parenthesis_when_callable_is_expected/lambda_body.cfg Normal file
View File

@@ -0,0 +1,7 @@
[output]
include=[
{"display": "print(…)", "insert_text": "print("},
]
exclude=[
{"insert_text": "print"},
]

5
modules/gdscript/tests/scripts/completion/no_parenthesis_when_callable_is_expected/lambda_body.gd Normal file
View File

@@ -0,0 +1,5 @@
signal test_signal
func _init() -> void:
test_signal.connect(func(): p➡
pass

7
modules/gdscript/tests/scripts/completion/no_parenthesis_when_callable_is_expected/lambda_parameter.cfg Normal file
View File

@@ -0,0 +1,7 @@
[output]
include=[
{"display": "print(…)", "insert_text": "print("},
]
exclude=[
{"insert_text": "print"},
]

5
modules/gdscript/tests/scripts/completion/no_parenthesis_when_callable_is_expected/lambda_parameter.gd Normal file
View File

@@ -0,0 +1,5 @@
signal test_signal
func _init() -> void:
test_signal.connect(func(a = p➡): pass
pass