godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

GDScript: Use pointer instead of references in cache

Browse Source 
They are not supposed to be kept alive and this is cleaner and less
error-prone than unreferencing the elements.
This commit is contained in:
George Marques
2020-08-23 11:19:35 -03:00
parent 58f5c2bab6
commit d36d7e2a1c
3 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/gdscript/gdscript.cpp
View File

@@ -603,10 +603,8 @@ Error GDScript::reload(bool p_keep_state) {
}
if (!source_path.empty()) {
MutexLock lock(GDScriptCache::singleton->lock);
Ref<GDScript> self(this);
if (!GDScriptCache::singleton->shallow_gdscript_cache.has(source_path)) {
GDScriptCache::singleton->shallow_gdscript_cache[source_path] = self;
self->unreference();
GDScriptCache::singleton->shallow_gdscript_cache[source_path] = this;
}
}
}