godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-08 12:40:44 +00:00
Code Releases Wiki Activity

Fix float/int comparison in acos_approx in sky template shader

Browse Source 
Strict GLSL implementations will not automatically convert `0` to a float
This commit is contained in:
clayjohn
2025-04-27 10:11:19 -07:00
parent e37c6261ea
commit d2dce41681
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gles3/shaders/sky.glsl
View File

@@ -157,7 +157,7 @@ float acos_approx(float p_x) {
float x = abs(p_x); float x = abs(p_x);
float res = -0.156583f * x + (M_PI / 2.0); float res = -0.156583f * x + (M_PI / 2.0);
res *= sqrt(1.0f - x); res *= sqrt(1.0f - x);
return (p_x >= 0) ? res : M_PI - res; return (p_x >= 0.0) ? res : M_PI - res;
} }
// Based on https://math.stackexchange.com/questions/1098487/atan2-faster-approximation // Based on https://math.stackexchange.com/questions/1098487/atan2-faster-approximation

2
servers/rendering/renderer_rd/shaders/environment/sky.glsl
View File

@@ -193,7 +193,7 @@ float acos_approx(float p_x) {
float x = abs(p_x); float x = abs(p_x);
float res = -0.156583f * x + (M_PI / 2.0); float res = -0.156583f * x + (M_PI / 2.0);
res *= sqrt(1.0f - x); res *= sqrt(1.0f - x);
return (p_x >= 0) ? res : M_PI - res; return (p_x >= 0.0) ? res : M_PI - res;
} }
// Based on https://math.stackexchange.com/questions/1098487/atan2-faster-approximation // Based on https://math.stackexchange.com/questions/1098487/atan2-faster-approximation