From af5f695a99addd052929c5dee9f3d7c9cd896814 Mon Sep 17 00:00:00 2001 From: Paul Joannon Date: Thu, 9 May 2024 15:24:54 +0200 Subject: [PATCH] Fix comparison warnings in `StringExtensions.cs` --- .../GodotSharp/GodotSharp/Core/StringExtensions.cs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs b/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs index c805b68c94e..ad75195f0fa 100644 --- a/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs +++ b/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs @@ -426,7 +426,9 @@ namespace Godot /// An integer that indicates the lexical relationship between the two comparands. public static int CasecmpTo(this string instance, string to) { - return instance.CompareTo(to, caseSensitive: true); +#pragma warning disable CA1309 // Use ordinal string comparison + return string.Compare(instance, to, ignoreCase: false, null); +#pragma warning restore CA1309 } /// @@ -441,7 +443,9 @@ namespace Godot [Obsolete("Use string.Compare instead.")] public static int CompareTo(this string instance, string to, bool caseSensitive = true) { - return string.Compare(instance, to, !caseSensitive); +#pragma warning disable CA1309 // Use ordinal string comparison + return string.Compare(instance, to, ignoreCase: !caseSensitive, null); +#pragma warning restore CA1309 } /// @@ -1261,7 +1265,9 @@ namespace Godot /// An integer that indicates the lexical relationship between the two comparands. public static int NocasecmpTo(this string instance, string to) { - return instance.CompareTo(to, caseSensitive: false); +#pragma warning disable CA1309 // Use ordinal string comparison + return string.Compare(instance, to, ignoreCase: true, null); +#pragma warning restore CA1309 } ///