godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Fix Tween follow_property finishing with null

Browse Source
This commit is contained in:
Mark Riedesel
2019-10-23 16:38:43 -04:00
parent 8c3a5057c5
commit d0b528e4a8
2 changed files with 42 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
scene/animation/tween.cpp
View File

@@ -281,7 +281,7 @@ void Tween::_bind_methods() {
BIND_ENUM_CONSTANT(EASE_OUT_IN); BIND_ENUM_CONSTANT(EASE_OUT_IN);
} }
Variant &Tween::_get_initial_val(InterpolateData &p_data) { Variant Tween::_get_initial_val(const InterpolateData &p_data) const {
// What type of data are we interpolating? // What type of data are we interpolating?
switch (p_data.type) { switch (p_data.type) {
@@ -299,7 +299,7 @@ Variant &Tween::_get_initial_val(InterpolateData &p_data) {
ERR_FAIL_COND_V(object == NULL, p_data.initial_val); ERR_FAIL_COND_V(object == NULL, p_data.initial_val);
// Are we targeting a property or a method? // Are we targeting a property or a method?
static Variant initial_val; Variant initial_val;
if (p_data.type == TARGETING_PROPERTY) { if (p_data.type == TARGETING_PROPERTY) {
// Get the property from the target object // Get the property from the target object
bool valid = false; bool valid = false;
@@ -322,6 +322,41 @@ Variant &Tween::_get_initial_val(InterpolateData &p_data) {
return p_data.delta_val; return p_data.delta_val;
} }
Variant Tween::_get_final_val(const InterpolateData &p_data) const {
switch (p_data.type) {
case FOLLOW_PROPERTY:
case FOLLOW_METHOD: {
// Get the object that is being followed
Object *target = ObjectDB::get_instance(p_data.target_id);
ERR_FAIL_COND_V(target == NULL, p_data.initial_val);
// We want to figure out the final value
Variant final_val;
if (p_data.type == FOLLOW_PROPERTY) {
// Read the property as-is
bool valid = false;
final_val = target->get_indexed(p_data.target_key, &valid);
ERR_FAIL_COND_V(!valid, p_data.initial_val);
} else {
// We're looking at a method. Call the method on the target object
Variant::CallError error;
final_val = target->call(p_data.target_key[0], NULL, 0, error);
ERR_FAIL_COND_V(error.error != Variant::CallError::CALL_OK, p_data.initial_val);
}
// If we're looking at an INT value, instead convert it to a REAL
// This is better for interpolation
if (final_val.get_type() == Variant::INT) final_val = final_val.operator real_t();
return final_val;
}
default: {
// If we're not following a final value/method, use the final value from the data
return p_data.final_val;
}
}
}
Variant &Tween::_get_delta_val(InterpolateData &p_data) { Variant &Tween::_get_delta_val(InterpolateData &p_data) {
// What kind of data are we interpolating? // What kind of data are we interpolating?
@@ -384,7 +419,7 @@ Variant &Tween::_get_delta_val(InterpolateData &p_data) {
Variant Tween::_run_equation(InterpolateData &p_data) { Variant Tween::_run_equation(InterpolateData &p_data) {
// Get the initial and delta values from the data // Get the initial and delta values from the data
Variant &initial_val = _get_initial_val(p_data); Variant initial_val = _get_initial_val(p_data);
Variant &delta_val = _get_delta_val(p_data); Variant &delta_val = _get_delta_val(p_data);
Variant result; Variant result;
@@ -718,7 +753,8 @@ void Tween::_tween_process(float p_delta) {
// Is the tween now finished? // Is the tween now finished?
if (data.finish) { if (data.finish) {
// Set it to the final value directly // Set it to the final value directly
_apply_tween_value(data, data.final_val); Variant final_val = _get_final_val(data);
_apply_tween_value(data, final_val);
// Mark the tween as completed and emit the signal // Mark the tween as completed and emit the signal
data.elapsed = 0; data.elapsed = 0;

3
scene/animation/tween.h
View File

@@ -127,7 +127,8 @@ private:
real_t _run_equation(TransitionType p_trans_type, EaseType p_ease_type, real_t t, real_t b, real_t c, real_t d); real_t _run_equation(TransitionType p_trans_type, EaseType p_ease_type, real_t t, real_t b, real_t c, real_t d);
Variant &_get_delta_val(InterpolateData &p_data); Variant &_get_delta_val(InterpolateData &p_data);
Variant &_get_initial_val(InterpolateData &p_data); Variant _get_initial_val(const InterpolateData &p_data) const;
Variant _get_final_val(const InterpolateData &p_data) const;
Variant _run_equation(InterpolateData &p_data); Variant _run_equation(InterpolateData &p_data);
bool _calc_delta_val(const Variant &p_initial_val, const Variant &p_final_val, Variant &p_delta_val); bool _calc_delta_val(const Variant &p_initial_val, const Variant &p_final_val, Variant &p_delta_val);
bool _apply_tween_value(InterpolateData &p_data, Variant &value); bool _apply_tween_value(InterpolateData &p_data, Variant &value);