From 4cc1d0ba67c9f3e775b90b2d672ab8742bae3e3a Mon Sep 17 00:00:00 2001 From: David Snopek Date: Wed, 18 Jun 2025 15:45:55 -0500 Subject: [PATCH] Revert "Use lower shadow normal bias for distant directional shadow splits" This reverts commit dfc05caf06fb9a2b6167be7f822aa86f4283ae7e. --- servers/rendering/renderer_rd/storage_rd/light_storage.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/servers/rendering/renderer_rd/storage_rd/light_storage.cpp b/servers/rendering/renderer_rd/storage_rd/light_storage.cpp index ddc41f973fb..bc5ad566cf1 100644 --- a/servers/rendering/renderer_rd/storage_rd/light_storage.cpp +++ b/servers/rendering/renderer_rd/storage_rd/light_storage.cpp @@ -714,9 +714,7 @@ void LightStorage::update_light_buffers(RenderDataRD *p_render_data, const Paged light_data.shadow_split_offsets[j] = split; float bias_scale = light_instance->shadow_transform[j].bias_scale * light_data.soft_shadow_scale; light_data.shadow_bias[j] = light->param[RS::LIGHT_PARAM_SHADOW_BIAS] / 100.0 * bias_scale; - // Use lower shadow normal bias for distant splits, relative to the share taken by the split. - // This helps reduce peter-panning at a distance. - light_data.shadow_normal_bias[j] = light->param[RS::LIGHT_PARAM_SHADOW_NORMAL_BIAS] * light_instance->shadow_transform[j].shadow_texel_size * light_data.shadow_split_offsets[0] / split; + light_data.shadow_normal_bias[j] = light->param[RS::LIGHT_PARAM_SHADOW_NORMAL_BIAS] * light_instance->shadow_transform[j].shadow_texel_size; light_data.shadow_transmittance_bias[j] = light->param[RS::LIGHT_PARAM_TRANSMITTANCE_BIAS] / 100.0 * bias_scale; light_data.shadow_z_range[j] = light_instance->shadow_transform[j].farplane; light_data.shadow_range_begin[j] = light_instance->shadow_transform[j].range_begin;