godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

VisualShader Conversion fails with Embeds

Browse Source 
Potentially resolves https://github.com/godotengine/godot/issues/101375

VisualShader now has a has_node_embeds function that runs through it's child nodes to find embedded resources via object properties. Conversion plugin uses this function to catch the error.
This commit is contained in:
Colin O'Rourke
2025-08-06 13:17:19 -07:00
parent 6efa557e9b
commit c4559c02de
5 changed files with 54 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
editor/inspector/editor_resource_picker.cpp
View File

@@ -484,8 +484,11 @@ void EditorResourcePicker::_edit_menu_cbk(int p_which) {
Vector<Ref<EditorResourceConversionPlugin>> conversions = EditorNode::get_singleton()->find_resource_conversion_plugin_for_resource(edited_resource);
ERR_FAIL_INDEX(to_type, conversions.size());
edited_resource = conversions[to_type]->convert(edited_resource);
_resource_changed();
Ref<Resource> converted_resource = conversions[to_type]->convert(edited_resource);
if (converted_resource.is_valid()) {
edited_resource = converted_resource;
_resource_changed();
}
break;
}