godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-13 13:31:48 +00:00
Code Releases Wiki Activity

Prevent overwriting open scenes when saving

Browse Source 
Prevent overwriting open scenes when saving, this fixes #17628
This commit is contained in:
DualMatrix
2018-09-07 15:54:26 +02:00
parent f1e5b7cf42
commit c43ffc8917
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
editor/editor_node.cpp
View File

@@ -1174,6 +1174,16 @@ void EditorNode::_dialog_action(String p_file) {
int scene_idx = (current_option == FILE_SAVE_SCENE || current_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing; int scene_idx = (current_option == FILE_SAVE_SCENE || current_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing;
if (file->get_mode() == EditorFileDialog::MODE_SAVE_FILE) { if (file->get_mode() == EditorFileDialog::MODE_SAVE_FILE) {
bool same_open_scene = false;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == p_file && i != scene_idx)
same_open_scene = true;
}
if (same_open_scene) {
show_warning(TTR("Can't overwrite scene that is still open!"));
return;
}
_save_default_environment(); _save_default_environment();
_save_scene_with_preview(p_file, scene_idx); _save_scene_with_preview(p_file, scene_idx);

7
editor/scene_tree_dock.cpp
View File

@@ -1816,6 +1816,13 @@ void SceneTreeDock::_new_scene_from(String p_file) {
return; return;
} }
if (EditorNode::get_singleton()->is_scene_open(p_file)) {
accept->get_ok()->set_text(TTR("OK"));
accept->set_text(TTR("Can't overwrite scene that is still open!"));
accept->popup_centered_minsize();
return;
}
Node *base = selection.front()->get(); Node *base = selection.front()->get();
Map<Node *, Node *> reown; Map<Node *, Node *> reown;