godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-10 13:00:37 +00:00
Code Releases Wiki Activity

Fix possible buffer overflow in NetworkedMultiplayerENet

Browse Source 
NetworkedMultiplayerENet::get_packet was reporting the wrong size for the packet buffer exposing a potential buffer overflow in case of malformed/malicious packets
This commit is contained in:
Fabio Alessandrelli
2016-09-30 03:37:09 +02:00
parent cb7661df94
commit c1dc71baee
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/enet/networked_multiplayer_enet.cpp
View File

@@ -359,7 +359,7 @@ Error NetworkedMultiplayerENet::get_packet(const uint8_t **r_buffer,int &r_buffe
incoming_packets.pop_front(); incoming_packets.pop_front();
*r_buffer=(const uint8_t*)(&current_packet.packet->data[12]); *r_buffer=(const uint8_t*)(&current_packet.packet->data[12]);
r_buffer_size=current_packet.packet->dataLength; r_buffer_size=current_packet.packet->dataLength-12;
return OK; return OK;
} }