godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

Fixes segfault on opening incompatible files.

Browse Source 
If a file cannot be opened by the plugin connected, the engine
would crash. This has been fixed by quitting the open_file() method
early.
This commit is contained in:
Anish
2019-03-11 16:37:22 +05:30
parent 91d3ea0d1f
commit bd22b1cbe6
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
modules/gdnative/videodecoder/video_stream_gdnative.cpp
View File

@@ -117,18 +117,20 @@ bool VideoStreamPlaybackGDNative::open_file(const String &p_file) {
file = FileAccess::open(p_file, FileAccess::READ); file = FileAccess::open(p_file, FileAccess::READ);
bool file_opened = interface->open_file(data_struct, file); bool file_opened = interface->open_file(data_struct, file);
num_channels = interface->get_channels(data_struct); if (file_opened) {
mix_rate = interface->get_mix_rate(data_struct); num_channels = interface->get_channels(data_struct);
mix_rate = interface->get_mix_rate(data_struct);
godot_vector2 vec = interface->get_texture_size(data_struct); godot_vector2 vec = interface->get_texture_size(data_struct);
texture_size = *(Vector2 *)&vec; texture_size = *(Vector2 *)&vec;
pcm = (float *)memalloc(num_channels * AUX_BUFFER_SIZE * sizeof(float)); pcm = (float *)memalloc(num_channels * AUX_BUFFER_SIZE * sizeof(float));
memset(pcm, 0, num_channels * AUX_BUFFER_SIZE * sizeof(float)); memset(pcm, 0, num_channels * AUX_BUFFER_SIZE * sizeof(float));
pcm_write_idx = -1; pcm_write_idx = -1;
samples_decoded = 0; samples_decoded = 0;
texture->create((int)texture_size.width, (int)texture_size.height, Image::FORMAT_RGBA8, Texture::FLAG_FILTER | Texture::FLAG_VIDEO_SURFACE); texture->create((int)texture_size.width, (int)texture_size.height, Image::FORMAT_RGBA8, Texture::FLAG_FILTER | Texture::FLAG_VIDEO_SURFACE);
}
return file_opened; return file_opened;
} }