godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-19 14:31:59 +00:00
Code Releases Wiki Activity

Merge pull request #102874 from YeldhamDev/fix_fav_no_parent

Browse Source 
Fix error with favorited properties with open sub-inspectors
This commit is contained in:
Rémi Verschelde
2025-02-15 23:09:56 +01:00
parent e5860ab63d b31c85cf3e
commit ba7b500b55
1 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
editor/editor_inspector.cpp
View File

@@ -3832,6 +3832,8 @@ void EditorInspector::update_tree() {
ep->set_doc_path(doc_path); ep->set_doc_path(doc_path);
ep->set_internal(p.usage & PROPERTY_USAGE_INTERNAL); ep->set_internal(p.usage & PROPERTY_USAGE_INTERNAL);
// If this property is favorited, it won't be in the tree yet. So don't do this setup right now.
if (ep->is_inside_tree()) {
ep->update_property(); ep->update_property();
ep->_update_flags(); ep->_update_flags();
ep->update_editor_property_status(); ep->update_editor_property_status();
@@ -3843,6 +3845,7 @@ void EditorInspector::update_tree() {
} }
} }
} }
}
if (!current_favorites.is_empty()) { if (!current_favorites.is_empty()) {
favorites_section->show(); favorites_section->show();
@@ -3891,6 +3894,16 @@ void EditorInspector::update_tree() {
for (EditorProperty *ep : KV2.value) { for (EditorProperty *ep : KV2.value) {
vbox->add_child(ep); vbox->add_child(ep);
// Now that it's inside the tree, do the setup.
ep->update_property();
ep->_update_flags();
ep->update_editor_property_status();
ep->update_cache();
if (current_selected && ep->property == current_selected) {
ep->select(current_focusable);
}
} }
} }
} }