godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-10 13:00:37 +00:00
Code Releases Wiki Activity

Fix crash in RenderingDeviceVulkan::shader_create

Browse Source 
This commit moves the declaration of a local variable to ensure its
scope survives long enough; at least in some versions of GCC and LLVM
the associated memory was freed too early and thus caused issues ranging
from black screens to crashes.
This commit is contained in:
rsjtdrjgfuzkfg
2020-10-25 00:56:54 +02:00
parent 6c173e2f7f
commit b1f95e150e
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/vulkan/rendering_device_vulkan.cpp
View File

@@ -4312,8 +4312,10 @@ RID RenderingDeviceVulkan::shader_create(const Vector<ShaderStageData> &p_stages
} }
pipeline_layout_create_info.pSetLayouts = layouts.ptr(); pipeline_layout_create_info.pSetLayouts = layouts.ptr();
// Needs to be declared in this outer scope, otherwise it may not outlive its assignment
// to pipeline_layout_create_info.
VkPushConstantRange push_constant_range;
if (push_constant.push_constant_size) { if (push_constant.push_constant_size) {
VkPushConstantRange push_constant_range;
push_constant_range.stageFlags = push_constant.push_constants_vk_stage; push_constant_range.stageFlags = push_constant.push_constants_vk_stage;
push_constant_range.offset = 0; push_constant_range.offset = 0;
push_constant_range.size = push_constant.push_constant_size; push_constant_range.size = push_constant.push_constant_size;