godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-07 12:30:27 +00:00
Code Releases Wiki Activity

Fix RenderingServer::mesh_surface_get_lods()

Browse Source 
This function was incorrectly using the surface number to index into the
LOD indices vector.  This resulted in just returning the same index over
and over again.  In theory if you had a mesh with more surfaces than one
of its LOD vectors it could read pass the end of the LOD index array.

The SoftBody3D code creates a new ArrayMesh by duplicating the input
mesh, and uses `mesh_surface_get_lods()` to duplicate the LODs.  The
broken behavior here results in SoftBody3D creating broken meshes that
render nothing due to each LOD just using a single vertex.  This commit
fixes SoftBody3D to now work correctly with meshes with LODs.

Fixes #107984.
This commit is contained in:
Adam Simpkins
2025-06-25 01:06:44 -07:00
parent 30456ba095
commit ad4dff7cbe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
servers/rendering_server.cpp
View File

@@ -1731,7 +1731,7 @@ Dictionary RenderingServer::mesh_surface_get_lods(RID p_mesh, int p_surface) con
const uint16_t *rptr = (const uint16_t *)r; const uint16_t *rptr = (const uint16_t *)r;
int *w = lods.ptrw(); int *w = lods.ptrw();
for (uint32_t j = 0; j < lc; j++) { for (uint32_t j = 0; j < lc; j++) {
w[j] = rptr[i]; w[j] = rptr[j];
} }
} else { } else {
uint32_t lc = sd.lods[i].index_data.size() / 4; uint32_t lc = sd.lods[i].index_data.size() / 4;
@@ -1740,7 +1740,7 @@ Dictionary RenderingServer::mesh_surface_get_lods(RID p_mesh, int p_surface) con
const uint32_t *rptr = (const uint32_t *)r; const uint32_t *rptr = (const uint32_t *)r;
int *w = lods.ptrw(); int *w = lods.ptrw();
for (uint32_t j = 0; j < lc; j++) { for (uint32_t j = 0; j < lc; j++) {
w[j] = rptr[i]; w[j] = rptr[j];
} }
} }