You've already forked godot
mirror of
https://github.com/godotengine/godot.git
synced 2025-11-15 13:51:40 +00:00
Improvements to multi-node editing
- Show revert button for properties that are not default for all selected nodes - Show property documentation tooltips - Show common class name and icon and number of selected nodes in EditorPath, e.g. "Node2D (4 Selected)" - Hide metadata for MultiNodeEdit and AnimationMultiTrackKeyEdit - Hide script for MultiNodeEdit
This commit is contained in:
@@ -46,7 +46,7 @@ bool MultiNodeEdit::_set_impl(const StringName &p_name, const Variant &p_value,
|
||||
|
||||
String name = p_name;
|
||||
|
||||
if (name == "scripts") { // script set is intercepted at object level (check Variant Object::get() ) ,so use a different name
|
||||
if (name == "scripts") { // Script set is intercepted at object level (check Variant Object::get()), so use a different name.
|
||||
name = "script";
|
||||
}
|
||||
|
||||
@@ -57,13 +57,9 @@ bool MultiNodeEdit::_set_impl(const StringName &p_name, const Variant &p_value,
|
||||
|
||||
Ref<EditorUndoRedoManager> &ur = EditorNode::get_undo_redo();
|
||||
|
||||
ur->create_action(TTR("MultiNode Set") + " " + String(name), UndoRedo::MERGE_ENDS);
|
||||
ur->create_action(vformat(TTR("Set %s on %d nodes"), name, get_node_count()), UndoRedo::MERGE_ENDS);
|
||||
for (const NodePath &E : nodes) {
|
||||
if (!es->has_node(E)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
Node *n = es->get_node(E);
|
||||
Node *n = es->get_node_or_null(E);
|
||||
if (!n) {
|
||||
continue;
|
||||
}
|
||||
@@ -100,16 +96,12 @@ bool MultiNodeEdit::_get(const StringName &p_name, Variant &r_ret) const {
|
||||
}
|
||||
|
||||
String name = p_name;
|
||||
if (name == "scripts") { // script set is intercepted at object level (check Variant Object::get() ) ,so use a different name
|
||||
if (name == "scripts") { // Script set is intercepted at object level (check Variant Object::get()), so use a different name.
|
||||
name = "script";
|
||||
}
|
||||
|
||||
for (const NodePath &E : nodes) {
|
||||
if (!es->has_node(E)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
const Node *n = es->get_node(E);
|
||||
const Node *n = es->get_node_or_null(E);
|
||||
if (!n) {
|
||||
continue;
|
||||
}
|
||||
@@ -137,11 +129,7 @@ void MultiNodeEdit::_get_property_list(List<PropertyInfo> *p_list) const {
|
||||
List<PLData *> data_list;
|
||||
|
||||
for (const NodePath &E : nodes) {
|
||||
if (!es->has_node(E)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
Node *n = es->get_node(E);
|
||||
Node *n = es->get_node_or_null(E);
|
||||
if (!n) {
|
||||
continue;
|
||||
}
|
||||
@@ -151,7 +139,7 @@ void MultiNodeEdit::_get_property_list(List<PropertyInfo> *p_list) const {
|
||||
|
||||
for (const PropertyInfo &F : plist) {
|
||||
if (F.name == "script") {
|
||||
continue; //added later manually, since this is intercepted before being set (check Variant Object::get() )
|
||||
continue; // Added later manually, since this is intercepted before being set (check Variant Object::get()).
|
||||
}
|
||||
if (!usage.has(F.name)) {
|
||||
PLData pld;
|
||||
@@ -161,7 +149,7 @@ void MultiNodeEdit::_get_property_list(List<PropertyInfo> *p_list) const {
|
||||
data_list.push_back(usage.getptr(F.name));
|
||||
}
|
||||
|
||||
// Make sure only properties with the same exact PropertyInfo data will appear
|
||||
// Make sure only properties with the same exact PropertyInfo data will appear.
|
||||
if (usage[F.name].info == F) {
|
||||
usage[F.name].uses++;
|
||||
}
|
||||
@@ -179,6 +167,66 @@ void MultiNodeEdit::_get_property_list(List<PropertyInfo> *p_list) const {
|
||||
p_list->push_back(PropertyInfo(Variant::OBJECT, "scripts", PROPERTY_HINT_RESOURCE_TYPE, "Script"));
|
||||
}
|
||||
|
||||
String MultiNodeEdit::_get_editor_name() const {
|
||||
return vformat(TTR("%s (%d Selected)"), get_edited_class_name(), get_node_count());
|
||||
}
|
||||
|
||||
bool MultiNodeEdit::_property_can_revert(const StringName &p_name) const {
|
||||
Node *es = EditorNode::get_singleton()->get_edited_scene();
|
||||
if (!es) {
|
||||
return false;
|
||||
}
|
||||
|
||||
if (ClassDB::has_property(get_edited_class_name(), p_name)) {
|
||||
StringName class_name;
|
||||
for (const NodePath &E : nodes) {
|
||||
Node *node = es->get_node_or_null(E);
|
||||
if (!node) {
|
||||
continue;
|
||||
}
|
||||
|
||||
class_name = node->get_class_name();
|
||||
}
|
||||
|
||||
Variant default_value = ClassDB::class_get_default_property_value(class_name, p_name);
|
||||
for (const NodePath &E : nodes) {
|
||||
Node *node = es->get_node_or_null(E);
|
||||
if (!node) {
|
||||
continue;
|
||||
}
|
||||
|
||||
if (node->get(p_name) != default_value) {
|
||||
// A node that doesn't have the default value has been found, so show the revert button.
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
// Don't show the revert button if the edited class doesn't have the property.
|
||||
return false;
|
||||
}
|
||||
|
||||
bool MultiNodeEdit::_property_get_revert(const StringName &p_name, Variant &r_property) const {
|
||||
Node *es = EditorNode::get_singleton()->get_edited_scene();
|
||||
if (!es) {
|
||||
return false;
|
||||
}
|
||||
|
||||
for (const NodePath &E : nodes) {
|
||||
Node *node = es->get_node_or_null(E);
|
||||
if (!node) {
|
||||
continue;
|
||||
}
|
||||
|
||||
r_property = ClassDB::class_get_default_property_value(node->get_class_name(), p_name);
|
||||
return true;
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
void MultiNodeEdit::add_node(const NodePath &p_node) {
|
||||
nodes.push_back(p_node);
|
||||
}
|
||||
@@ -192,9 +240,69 @@ NodePath MultiNodeEdit::get_node(int p_index) const {
|
||||
return nodes[p_index];
|
||||
}
|
||||
|
||||
StringName MultiNodeEdit::get_edited_class_name() const {
|
||||
Node *es = EditorNode::get_singleton()->get_edited_scene();
|
||||
if (!es) {
|
||||
return SNAME("Node");
|
||||
}
|
||||
|
||||
// Get the class name of the first node.
|
||||
StringName class_name;
|
||||
for (const NodePath &E : nodes) {
|
||||
Node *node = es->get_node_or_null(E);
|
||||
if (!node) {
|
||||
continue;
|
||||
}
|
||||
|
||||
class_name = node->get_class_name();
|
||||
break;
|
||||
}
|
||||
|
||||
if (class_name == StringName()) {
|
||||
return SNAME("Node");
|
||||
}
|
||||
|
||||
bool check_again = true;
|
||||
while (check_again) {
|
||||
check_again = false;
|
||||
|
||||
if (class_name == SNAME("Node") || class_name == StringName()) {
|
||||
// All nodes inherit from Node, so no need to continue checking.
|
||||
return SNAME("Node");
|
||||
}
|
||||
|
||||
// Check that all nodes inherit from class_name.
|
||||
for (const NodePath &E : nodes) {
|
||||
Node *node = es->get_node_or_null(E);
|
||||
if (!node) {
|
||||
continue;
|
||||
}
|
||||
|
||||
const StringName node_class_name = node->get_class_name();
|
||||
if (class_name == node_class_name || ClassDB::is_parent_class(node_class_name, class_name)) {
|
||||
// class_name is the same or a parent of the node's class.
|
||||
continue;
|
||||
}
|
||||
|
||||
// class_name is not a parent of the node's class, so check again with the parent class.
|
||||
class_name = ClassDB::get_parent_class(class_name);
|
||||
check_again = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
return class_name;
|
||||
}
|
||||
|
||||
void MultiNodeEdit::set_property_field(const StringName &p_property, const Variant &p_value, const String &p_field) {
|
||||
_set_impl(p_property, p_value, p_field);
|
||||
}
|
||||
|
||||
void MultiNodeEdit::_bind_methods() {
|
||||
ClassDB::bind_method("_hide_script_from_inspector", &MultiNodeEdit::_hide_script_from_inspector);
|
||||
ClassDB::bind_method("_hide_metadata_from_inspector", &MultiNodeEdit::_hide_metadata_from_inspector);
|
||||
ClassDB::bind_method("_get_editor_name", &MultiNodeEdit::_get_editor_name);
|
||||
}
|
||||
|
||||
MultiNodeEdit::MultiNodeEdit() {
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user