godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-21 14:57:09 +00:00
Code Releases Wiki Activity

Better zeroizing in CryptoKey.

Browse Source
This commit is contained in:
Fabio Alessandrelli
2020-06-07 17:27:22 +02:00
parent 8e68f2e5f4
commit a486783d3d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/mbedtls/crypto_mbedtls.cpp
View File

@@ -84,14 +84,14 @@ Error CryptoKeyMbedTLS::save(String p_path) {
int ret = mbedtls_pk_write_key_pem(&pkey, w, sizeof(w)); int ret = mbedtls_pk_write_key_pem(&pkey, w, sizeof(w));
if (ret != 0) { if (ret != 0) {
memdelete(f); memdelete(f);
memset(w, 0, sizeof(w)); // Zeroize anything we might have written. mbedtls_platform_zeroize(w, sizeof(w)); // Zeroize anything we might have written.
ERR_FAIL_V_MSG(FAILED, "Error writing key '" + itos(ret) + "'."); ERR_FAIL_V_MSG(FAILED, "Error writing key '" + itos(ret) + "'.");
} }
size_t len = strlen((char *)w); size_t len = strlen((char *)w);
f->store_buffer(w, len); f->store_buffer(w, len);
memdelete(f); memdelete(f);
memset(w, 0, sizeof(w)); // Zeroize temporary buffer. mbedtls_platform_zeroize(w, sizeof(w)); // Zeroize temporary buffer.
return OK; return OK;
} }