godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-15 13:51:40 +00:00
Code Releases Wiki Activity

Improve use of Ref.is_null/valid

Browse Source 
Use `is_null` over `!is_valid` and vice versa.
This commit is contained in:
A Thousand Ships
2024-08-25 14:15:10 +02:00
committed by AThousandShips
parent 0f95e9f8e6
commit a1846b27ea
177 changed files with 517 additions and 519 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scene/resources/bone_map.cpp
View File

@@ -65,11 +65,11 @@ Ref<SkeletonProfile> BoneMap::get_profile() const {
void BoneMap::set_profile(const Ref<SkeletonProfile> &p_profile) {
bool is_changed = profile != p_profile;
if (is_changed) {
if (!profile.is_null() && profile->is_connected("profile_updated", callable_mp(this, &BoneMap::_update_profile))) {
if (profile.is_valid() && profile->is_connected("profile_updated", callable_mp(this, &BoneMap::_update_profile))) {
profile->disconnect("profile_updated", callable_mp(this, &BoneMap::_update_profile));
}
profile = p_profile;
if (!profile.is_null()) {
if (profile.is_valid()) {
profile->connect("profile_updated", callable_mp(this, &BoneMap::_update_profile));
}
_update_profile();