godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Improve use of Ref.is_null/valid

Browse Source 
Use `is_null` over `!is_valid` and vice versa.
This commit is contained in:
A Thousand Ships
2024-08-25 14:15:10 +02:00
committed by AThousandShips
parent 0f95e9f8e6
commit a1846b27ea
177 changed files with 517 additions and 519 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scene/gui/video_stream_player.cpp
View File

@@ -81,10 +81,10 @@ void VideoStreamPlayer::_mix_audios(void *p_self) {
// Called from audio thread
void VideoStreamPlayer::_mix_audio() {
if (!stream.is_valid()) {
if (stream.is_null()) {
return;
}
if (!playback.is_valid() || !playback->is_playing() || playback->is_paused()) {
if (playback.is_null() || !playback->is_playing() || playback->is_paused()) {
return;
}
@@ -211,7 +211,7 @@ void VideoStreamPlayer::_notification(int p_notification) {
}
Size2 VideoStreamPlayer::get_minimum_size() const {
if (!expand && !texture.is_null()) {
if (!expand && texture.is_valid()) {
return texture->get_size();
} else {
return Size2();
@@ -264,7 +264,7 @@ void VideoStreamPlayer::set_stream(const Ref<VideoStream> &p_stream) {
stream->connect_changed(callable_mp(this, &VideoStreamPlayer::set_stream).bind(stream));
}
if (!playback.is_null()) {
if (playback.is_valid()) {
playback->set_paused(paused);
texture = playback->get_texture();