godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-06 12:20:30 +00:00
Code Releases Wiki Activity

Improve use of Ref.is_null/valid

Browse Source 
Use `is_null` over `!is_valid` and vice versa.
This commit is contained in:
A Thousand Ships
2024-08-25 14:15:10 +02:00
committed by AThousandShips
parent 0f95e9f8e6
commit a1846b27ea
177 changed files with 517 additions and 519 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
editor/plugins/texture_3d_editor_plugin.cpp
View File

@@ -165,13 +165,13 @@ void Texture3DEditor::_update_gui() {
}
void Texture3DEditor::edit(Ref<Texture3D> p_texture) {
if (!texture.is_null()) {
if (texture.is_valid()) {
texture->disconnect_changed(callable_mp(this, &Texture3DEditor::_texture_changed));
}
texture = p_texture;
if (!texture.is_null()) {
if (texture.is_valid()) {
if (shader.is_null()) {
_make_shaders();
}
@@ -235,7 +235,7 @@ Texture3DEditor::Texture3DEditor() {
}
Texture3DEditor::~Texture3DEditor() {
if (!texture.is_null()) {
if (texture.is_valid()) {
texture->disconnect_changed(callable_mp(this, &Texture3DEditor::_texture_changed));
}
}