godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-03 16:55:53 +00:00
Code Releases Wiki Activity

Merge pull request #36733 from qarmin/static_analyzer_fixes

Browse Source 
Fixes bugs found by Sonarcloud and Coverity
This commit is contained in:
Rémi Verschelde
2020-03-04 13:41:38 +01:00
committed by GitHub
parent f83f1d7c9b 1f209bfc41
commit a0e33e17fb
10 changed files with 25 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
servers/visual/rasterizer_rd/rasterizer_effects_rd.cpp
View File

@@ -1081,7 +1081,7 @@ RasterizerEffectsRD::~RasterizerEffectsRD() {
RD::get_singleton()->free(filter.image_uniform_set);
}
if (RD::get_singleton()->uniform_set_is_valid(filter.image_uniform_set)) {
if (RD::get_singleton()->uniform_set_is_valid(filter.uniform_set)) {
RD::get_singleton()->free(filter.uniform_set);
}

6
servers/visual/rasterizer_rd/rasterizer_storage_rd.cpp
View File

@@ -1906,8 +1906,10 @@ void RasterizerStorageRD::mesh_add_surface(RID p_mesh, const VS::SurfaceData &p_
for (int i = 0; i < p_surface.blend_shapes.size(); i++) {
ERR_FAIL_COND(p_surface.blend_shapes[i].size() != p_surface.vertex_data.size());
if (p_surface.blend_shapes[i].size() != p_surface.vertex_data.size()) {
memdelete(s);
ERR_FAIL_COND(p_surface.blend_shapes[i].size() != p_surface.vertex_data.size());
}
RID vertex_buffer = RD::get_singleton()->vertex_buffer_create(p_surface.blend_shapes[i].size(), p_surface.blend_shapes[i]);
s->blend_shapes.push_back(vertex_buffer);
}