godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-17 14:11:06 +00:00
Code Releases Wiki Activity

Add editor vital redraws only option

Browse Source 
When editor continuous redraws is switched off, the editor only redraws when a redraw_request was issued by an element in the scene. This works well in most situations, but when scenes have dynamic content they will continuously issue redraw_requests.

This can be fine on high power desktops but can be an annoyance on lower power machines.

This PR splits redraw requests into high and low priority requests, defaulting to high priority. Requests due to e.g. shaders using TIME are assigned low priority.

An extra editor setting is used to record the user preference and an extra option is added to the editor spinner menu, to allow the user to select between 3 modes:

* Continuous
* Update all changes
* Update vital changes
This commit is contained in:
lawnjelly
2021-10-05 19:05:57 +01:00
parent b6dbff7621
commit a0c6d16c90
26 changed files with 190 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
servers/visual/visual_server_raster.h
View File

@@ -53,7 +53,8 @@ class VisualServerRaster : public VisualServer {
};
static int changes;
// low and high priority
static int changes[2];
RID test_cube;
int black_margin[4];
@@ -68,27 +69,36 @@ class VisualServerRaster : public VisualServer {
List<FrameDrawnCallbacks> frame_drawn_callbacks;
void _draw_margins();
static void _changes_changed() {}
public:
//if editor is redrawing when it shouldn't, enable this and put a breakpoint in _changes_changed()
//#define DEBUG_CHANGES
#ifdef DEBUG_CHANGES
_FORCE_INLINE_ static void redraw_request() {
changes++;
_changes_changed();
// This function is NOT dead code.
// It is specifically for debugging redraws to help identify problems with
// undesired constant editor updating.
// The function will be called in DEV builds (and thus does not require a recompile),
// allowing you to place a breakpoint either at the first line or the semicolon.
// You can then look at the callstack to find the cause of the redraw.
static void _changes_changed(int p_priority) {
if (p_priority) {
;
}
}
#define DISPLAY_CHANGED \
changes++; \
_changes_changed();
public:
// if editor is redrawing when it shouldn't, use a DEV build and put a breakpoint in _changes_changed()
_FORCE_INLINE_ static void redraw_request(bool p_high_priority = true) {
int priority = p_high_priority ? 1 : 0;
changes[priority] += 1;
#ifdef DEV_ENABLED
_changes_changed(priority);
#endif
}
#ifdef DEV_ENABLED
#define DISPLAY_CHANGED \
changes[1] += 1; \
_changes_changed(1);
#else
_FORCE_INLINE_ static void redraw_request() { changes++; }
#define DISPLAY_CHANGED \
changes++;
changes[1] += 1;
#endif
#define BIND0R(m_r, m_name) \
@@ -736,7 +746,7 @@ public:
virtual void draw(bool p_swap_buffers, double frame_step);
virtual void sync();
virtual bool has_changed() const;
virtual bool has_changed(ChangedPriority p_priority = CHANGED_PRIORITY_ANY) const;
virtual void init();
virtual void finish();