From 9b2d77a23826d0bfaadb13f9d9d98a3e15ea1830 Mon Sep 17 00:00:00 2001 From: Per Melin Date: Fri, 1 Mar 2024 13:17:25 +0100 Subject: [PATCH] Initialize particle trail history frame numbers Fixes #88712 All particle trail sections were activated at once on the first cycle, instead of being spread out over the trail's lifetime. --- .../rendering/renderer_rd/storage_rd/particles_storage.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/servers/rendering/renderer_rd/storage_rd/particles_storage.cpp b/servers/rendering/renderer_rd/storage_rd/particles_storage.cpp index a854e78f536..73ac8750585 100644 --- a/servers/rendering/renderer_rd/storage_rd/particles_storage.cpp +++ b/servers/rendering/renderer_rd/storage_rd/particles_storage.cpp @@ -1452,6 +1452,11 @@ void ParticlesStorage::update_particles() { if (uint32_t(history_size) != particles->frame_history.size()) { particles->frame_history.resize(history_size); memset(particles->frame_history.ptr(), 0, sizeof(ParticlesFrameParams) * history_size); + // Set the frame number so that we are able to distinguish an uninitialized + // frame from the true frame number zero. See issue #88712 for details. + for (int i = 0; i < history_size; i++) { + particles->frame_history[i].frame = UINT32_MAX; + } } if (uint32_t(trail_steps) != particles->trail_params.size() || particles->frame_params_buffer.is_null()) {